Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smif app fails to render some pages some of the time #329

Open
tomalrussell opened this issue Mar 20, 2019 · 0 comments
Open

smif app fails to render some pages some of the time #329

tomalrussell opened this issue Mar 20, 2019 · 0 comments

Comments

@tomalrussell
Copy link
Member

With nismod/nismod2 config, flushes out some fragile assumptions:

  • sos_model scenarios should be lists (not objects)
  • scenario description should be empty string - this might be coming back as a list

Probabe fixes for these with:
a) stronger guarantees that the API returns well-formed data structures
b) stronger error boundaries on the client (at least avoid total white-screen failure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants