fix: clearer dms parsing

nobkd · Apr 4, 2023 · ca264ad · ca264ad
1 parent fd10f3e
commit ca264ad
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/src/map/utils/parseDMS.ts b/src/map/utils/parseDMS.ts
@@ -1,20 +1,16 @@
 export function parseDMS(input: string): [number, number] {
     let parts: string[] = input.split(/[^\d\w\.]+/);
-    let lat = convertDMSToDD(parts[0], parts[1], parts[2], parts[3]);
-    let lng = convertDMSToDD(parts[4], parts[5], parts[6], parts[7]);
+    let lat = convertDMSToDD(parts.slice(0, 4));
+    let lng = convertDMSToDD(parts.slice(4));
 
     return [lat, lng];
 }
 
-function convertDMSToDD(
-    degrees: string,
-    minutes: string,
-    seconds: string,
-    direction: string
-): number {
+function convertDMSToDD(dmsd: string[]): number {
+    const [degrees, minutes, seconds, direction] = dmsd;
     let dd = Number(degrees) + Number(minutes) / 60 + Number(seconds) / (60 * 60);
 
-    if (direction == 'S' || direction == 'W') {
+    if (direction === 'S' || direction === 'W') {
         dd = dd * -1;
     } // Don't do anything for N or E
     return dd;