Skip to content

Commit

Permalink
tools: update V8 gypfiles for 9.5
Browse files Browse the repository at this point in the history
PR-URL: #40178
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
targos committed Oct 12, 2021
1 parent c9296b1 commit 1fd9845
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 16 deletions.
4 changes: 0 additions & 4 deletions common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,6 @@
'v8_enable_pointer_compression%': 0,
'v8_enable_31bit_smis_on_64bit_arch%': 0,

# Disable V8 untrusted code mitigations.
# See https://github.com/v8/v8/wiki/Untrusted-code-mitigations
'v8_untrusted_code_mitigations': 0,

# This is more of a V8 dev setting
# https://github.com/nodejs/node/pull/22920/files#r222779926
'v8_enable_fast_mksnapshot': 0,
Expand Down
6 changes: 0 additions & 6 deletions tools/v8_gypfiles/features.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,6 @@
# Controls the threshold for on-heap/off-heap Typed Arrays.
'v8_typed_array_max_size_in_heap%': 64,

# Enable mitigations for executing untrusted code.
'v8_untrusted_code_mitigations%': 1,

# Enable minor mark compact.
'v8_enable_minor_mc%': 1,

Expand Down Expand Up @@ -358,9 +355,6 @@
['v8_enable_verify_csa==1', {
'defines': ['ENABLE_VERIFY_CSA',],
}],
['v8_untrusted_code_mitigations==0', {
'defines': ['DISABLE_UNTRUSTED_CODE_MITIGATIONS',],
}],
['v8_use_perfetto==1', {
'defines': ['V8_USE_PERFETTO',],
}],
Expand Down
7 changes: 1 addition & 6 deletions tools/v8_gypfiles/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -509,12 +509,7 @@
],
'direct_dependent_settings': {
'sources': [
'<(V8_ROOT)/include/v8-cppgc.h',
'<(V8_ROOT)/include/v8-fast-api-calls.h',
'<(V8_ROOT)/include/v8-internal.h',
'<(V8_ROOT)/include/v8-profiler.h',
'<(V8_ROOT)/include/v8-util.h',
'<(V8_ROOT)/include/v8.h',
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_header_set.\\"v8_headers\\".*?sources = ")',

'<(V8_ROOT)/include/v8-wasm-trap-handler-posix.h',
'<(V8_ROOT)/include/v8-wasm-trap-handler-win.h',
Expand Down

0 comments on commit 1fd9845

Please sign in to comment.