Skip to content

Commit

Permalink
build: do not indent assignments in Makefile
Browse files Browse the repository at this point in the history
Indented assignment in a Makefile can be interpreted
as a command in e.g. GNU Make 3.81 which results in the
following error:

```
make: CPPLINT_QUIET: No such file or directory
```

PR-URL: #29623
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
joyeecheung authored and BridgeAR committed Sep 25, 2019
1 parent 67f5de9 commit 5c24bc6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -1312,9 +1312,9 @@ else
endif

ifeq ($(V),1)
CPPLINT_QUIET =
CPPLINT_QUIET =
else
CPPLINT_QUIET = --quiet
CPPLINT_QUIET = --quiet
endif
.PHONY: lint-cpp
# Lints the C++ code with cpplint.py and check-imports.py.
Expand Down

0 comments on commit 5c24bc6

Please sign in to comment.