From fa145036026b6dc4b09bda0e2cc330aa46b2a705 Mon Sep 17 00:00:00 2001 From: Matheus Marchini Date: Mon, 17 Sep 2018 17:05:27 -0300 Subject: [PATCH] doc: move perf tools and APIs to Tier 3 V8 CodeEventHandler, V8 CpuProfiler, Linux perf and the `--interpreted-frames-native-stack`, `--prof` and `--prof-process` flags satisfies our Diagnostics Support requirements for Tier 3. V8 CodeEventHandler and CpuProfiler are tested as part of our V8 CI, and `Linux perf` / `--interpreted-frames-native-stack` are tested by `test/v8-updates/test-linux-perf.js`. `--prof` and `--prof-process` are tested in Node.js test suite. PR-URL: https://github.com/nodejs/node/pull/22915 Reviewed-By: Gireesh Punathil Reviewed-By: Joyee Cheung Reviewed-By: Michael Dawson --- doc/guides/diagnostic-tooling-support-tiers.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/guides/diagnostic-tooling-support-tiers.md b/doc/guides/diagnostic-tooling-support-tiers.md index 6f5e9e1494832e..189c75c1974d02 100644 --- a/doc/guides/diagnostic-tooling-support-tiers.md +++ b/doc/guides/diagnostic-tooling-support-tiers.md @@ -106,9 +106,13 @@ The tools are currently assigned to Tiers as follows: ## Tier 3 - | Tool Type | Tool/API Name | Regular Testing in Node.js CI | Integrated with Node.js | Target Tier | - |-----------|---------------------------|-------------------------------|-------------------------|-------------| - | | | | | | + | Tool Type | Tool/API Name | Regular Testing in Node.js CI | Integrated with Node.js | Target Tier | + |-----------|--------------------------------------|-------------------------------|-------------------------|-------------| + | Profiling | V8 CPU profiler | Partial (V8 Tests) | Yes | 1 | + | Profiling | --prof/--prof-process flags | Yes | Yes | 1 | + | Profiling | V8 CodeEventHandler API | Partial (V8 Tests) | Yes | 2 | + | Profiling | V8 --interpreted-frames-native-stack | Yes | Yes | 2 | + | Profiling | Linux perf | Yes | Partial | 2 | ## Tier 4 @@ -136,10 +140,6 @@ The tools are currently assigned to Tiers as follows: | Tracing | LTTng | No | Removed? | N/A | | Tracing | ETW | No | Partial | 3 | | Tracing | Systemtap | No | Partial | ? | - | Profiling | V8 CPU profiler (--prof) | No | Yes | 1 | - | Profiling | V8 CodeEventHandler API | No | Yes | ? | - | Profiling | V8 --interpreted-frames-native-stack | Yes | Yes | ? | - | Profiling | Linux perf | Yes | Partial | ? | | Profiling | DTrace | No | Partial | 3 | | Profiling | Windows Xperf | No | ? | ? | | Profiling | 0x | No | No | 4 |