Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure in test-worker-init-failure.js when running with --node-builtin-modules-path #40879

Closed
ronag opened this issue Nov 19, 2021 · 5 comments · Fixed by #42834
Closed

Test failure in test-worker-init-failure.js when running with --node-builtin-modules-path #40879

ronag opened this issue Nov 19, 2021 · 5 comments · Fixed by #42834
Labels
worker Issues and PRs related to Worker support.

Comments

@ronag
Copy link
Member

ronag commented Nov 19, 2021

#40852 (comment)

@nodejs/workers @addaleax @jasnell With the js changes in #40852, I get an assertion error now in out/Release/node test/parallel/test-worker-init-failure.js.

Looks like a workers bug.

child stderr: /Users/ronagy/GitHub/node/out/Release/node[68782]: ../../src/node_worker.cc:317:void node::worker::Worker::Run(): Assertion `(env_) != nullptr' failed.
/Users/ronagy/GitHub/node/out/Release/node[68782]: ../../src/node_worker.cc:317:void node::worker::Worker::Run(): Assertion `(env_) != nullptr' failed.
/Users/ronagy/GitHub/node/out/Release/node[68782]: ../../src/node_worker.cc:317:void node::worker::Worker::Run(): Assertion `(env_) != nullptr' failed.
 1: 0x104464444 node::Abort() [/Users/ronagy/GitHub/node/out/Release/node]
 1: 0x104464444 node::Abort() [/Users/ronagy/GitHub/node/out/Release/node]
 2: 0x10446428c node::AppendExceptionLine(node::Environment*, v8::Local<v8::Value>, v8::Local<v8::Message>, node::ErrorHandlingMode) [/Users/ronagy/GitHub/node/out/Release/node]
 1: 0x104464444 node::Abort() [/Users/ronagy/GitHub/node/out/Release/node]
 3: 0x1044f57dc node::worker::Worker::Run() [/Users/ronagy/GitHub/node/out/Release/node]
 2: 0x10446428c node::AppendExceptionLine(node::Environment*, v8::Local<v8::Value>, v8::Local<v8::Message>, node::ErrorHandlingMode) [/Users/ronagy/GitHub/node/out/Release/node]
 2: 0x10446428c node::AppendExceptionLine(node::Environment*, v8::Local<v8::Value>, v8::Local<v8::Message>, node::ErrorHandlingMode) [/Users/ronagy/GitHub/node/out/Release/node]
 4: 0x1044f885c node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::__invoke(void*) [/Users/ronagy/GitHub/node/out/Release/node]
 5: 0x18c7894ec _pthread_start [/usr/lib/system/libsystem_pthread.dylib]
 6: 0x18c7842d0 thread_start [/usr/lib/system/libsystem_pthread.dylib]
/bin/sh: line 1: 68782 Abort trap: 6           /Users/ronagy/GitHub/node/out/Release/node /Users/ronagy/GitHub/node/test/parallel/test-worker-init-failure.js child
@ronag ronag added the worker Issues and PRs related to Worker support. label Nov 19, 2021
@addaleax
Copy link
Member

@ronag I can’t reproduce on 9e99842 with default configure flags on x64 Ubuntu Linux.

What happens when you add --print-all-exceptions to the child process command line in the test?

@ronag
Copy link
Member Author

ronag commented Nov 19, 2021 •
edited
Loading

afa33ce

OSX Monterey, M1 Max

node$ out/Release/node test/parallel/test-worker-init-failure.js
child stdout: =========================================================
Exception thrown:
=========================================================
Exception thrown:
=========================================================
Exception thrown:
0x10a8bb865e51: [JS_ERROR_TYPE]
 - map: 0x2e3af92d14f9 <Map(HOLEY_ELEMENTS)> [FastProperties]
 - prototype: 0x0337f72077e1 <Object map = 0x2e3af92c1791>
 - elements: 0x16fe05401309 <FixedArray[0]> [HOLEY_ELEMENTS]
 - properties: 0x16fe05401309 <FixedArray[0]>
 - All own properties (excluding elements): {
    0x16fe054054e1: [String] in ReadOnlySpace: #stack: 0x3b8b4c9812d9 <AccessorInfo> (const accessor descriptor), location: descriptor
    0x16fe05404e41: [String] in ReadOnlySpace: #message: 0x10a8bb865dc9 <String[113]: "Cannot read local builtin. EMFILE: too many open files "/Users/ronagy/GitHub/node/lib/internal/bootstrap/node.js""> (const data field 0), location: in-object
    0x16fe05405b09 <Symbol: (stack_trace_symbol)>: 0x16fe05401309 <FixedArray[0]> (const data field 1), location: in-object
 }
Stack Trace:
=========================================================
=========================================================
Exception thrown:
0x375bfc005d49: [JS_ERROR_TYPE]
 - map: 0x1ad406b47611 <Map(HOLEY_ELEMENTS)> [FastProperties]
 - prototype: 0x2ecbc3f477e1 <Object map = 0x1ad406b41791>
 - elements: 0x3d8f8fa01309 <FixedArray[0]> [HOLEY_ELEMENTS]
 - properties: 0x3d8f8fa01309 <FixedArray[0]>
 - All own properties (excluding elements): {
    0x3d8f8fa054e1: [String] in ReadOnlySpace: #stack: 0x348f575c12d9 <AccessorInfo> (const accessor descriptor), location: descriptor
    0x3d8f8fa04e41: [String] in ReadOnlySpace: #message: 0x375bfc005cb9 <String[122]: "Cannot read local builtin. EMFILE: too many open files "/Users/ronagy/GitHub/node/lib/internal/per_context/primordials.js""> (const data field 0), location: in-object
    0x3d8f8fa05b09 <Symbol: (stack_trace_symbol)>: 0x3d8f8fa01309 <FixedArray[0]> (const data field 1), location: in-object
 }
Stack Trace:
=========================================================
=========================================================
Exception thrown:
0x3b36325a1169: [JS_ERROR_TYPE]
 - map: 0x117724f4fd59 <Map(HOLEY_ELEMENTS)> [FastProperties]
 - prototype: 0x17f2c31077e1 <Object map = 0x117724f41791>=========================================================
=========================================================
Exception thrown:
=========================================================
Exception thrown:
Exception thrown:
=========================================================
Exception thrown:
=========================================================
Exception thrown:

 - elements: 0x307297081309 <FixedArray[0]> [HOLEY_ELEMENTS]
 - properties: 0x307297081309 <FixedArray[0]>
 - All own properties (excluding elements): {
    0x3072970854e1: [String] in ReadOnlySpace: #stack: 0x23c1bf7c12d9 <AccessorInfo> (const accessor descriptor), location: descriptor
    0x307297084e41: [String] in ReadOnlySpace: #message: 0x3b36325a10d9 <String[122]: "Cannot read local builtin. EMFILE: too many open files "/Users/ronagy/GitHub/node/lib/internal/per_context/messageport.js""> (const data field 0), location: in-object
    0x307297085b09 <Symbol: (stack_trace_symbol)>: 0x307297081309 <FixedArray[0]> (const data field 1), location: in-object
 }
Stack Trace:
=========================================================
=========================================================
Exception thrown:
0x1520f762bda9: [JS_ERROR_TYPE]
 - map: 0x0bd2b540bc19 <Map(HOLEY_ELEMENTS)> [FastProperties]
 - prototype: 0x292d7ab077e1 <Object map = 0xbd2b5401791>
 - elements: 0x1adca4b41309 <FixedArray[0]> [HOLEY_ELEMENTS]
 - properties: 0x1adca4b41309 <FixedArray[0]>
 - All own properties (excluding elements): {
    0x1adca4b454e1: [String] in ReadOnlySpace: #stack: 0x08882bf812d9 <AccessorInfo> (const accessor descriptor), location: descriptor
    0x1adca4b44e41: [String] in ReadOnlySpace: #message: 0x1520f762bd19 <String[123]: "Cannot read local builtin. EMFILE: too many open files "/Users/ronagy/GitHub/node/lib/internal/per_context/domexception.js""> (const data field 0), location: in-object
    0x1adca4b45b09 <Symbol: (stack_trace_symbol)>: 0x1adca4b41309 <FixedArray[0]> (const data field 1), location: in-object
 }
=========================================================
Exception thrown:
Stack Trace:
=========================================================
0x19269fa68d1: [JS_ERROR_TYPE]
 - map: 0x02f908dd14f9 <Map(HOLEY_ELEMENTS)> [FastProperties]
 - prototype: 0x3c6419a877e1 <Object map = 0x2f908dc1791>
 - elements: 0x1d39eb7c1309 <FixedArray[0]> [HOLEY_ELEMENTS]
 - properties: 0x1d39eb7c1309 <FixedArray[0]>
 - All own properties (excluding elements): {
    0x1d39eb7c54e1: [String] in ReadOnlySpace: #stack: 0x3430037c12d9 <AccessorInfo> (const accessor descriptor), location: descriptor
    0x1d39eb7c4e41: [String] in ReadOnlySpace: #message: 0x019269fa6849 <String[113]: "Cannot read local builtin. EMFILE: too many open files "/Users/ronagy/GitHub/node/lib/internal/bootstrap/node.js""> (const data field 0), location: in-object
    0x1d39eb7c5b09 <Symbol: (stack_trace_symbol)>: 0x1d39eb7c1309 <FixedArray[0]> (const data field 1), location: in-object
 }
Stack Trace:
=========================================================
0x1cf982365da9: [JS_ERROR_TYPE]
 - map: 0x1fd3b40914f9 <Map(HOLEY_ELEMENTS)> [FastProperties]
 - prototype: 0x0acdc45077e1 <Object map = 0x1fd3b4081791>
 - elements: 0x399814d41309 <FixedArray[0]> [HOLEY_ELEMENTS]
 - properties: 0x399814d41309 <FixedArray[0]>
 - All own properties (excluding elements): {
    0x399814d454e1: [String] in ReadOnlySpace: #stack: 0x3150c3bc12d9 <AccessorInfo> (const accessor descriptor), location: descriptor
    0x399814d44e41: [String] in ReadOnlySpace: #message: 0x1cf982365d21 <String[113]: "Cannot read local builtin. EMFILE: too many open files "/Users/ronagy/GitHub/node/lib/internal/bootstrap/node.js""> (const data field 0), location: in-object
    0x399814d45b09 <Symbol: (stack_trace_symbol)>: 0x399814d41309 <FixedArray[0]> (const data field 1), location: in-object
 }
Stack Trace:
=========================================================
0x395d9ba45d49: [JS_ERROR_TYPE]
 - map: 0x162cf02c7611 <Map(HOLEY_ELEMENTS)> [FastProperties]
 - prototype: 0x0acb48e877e1 <Object map = 0x162cf02c1791>
 - elements: 0x024bc0781309 <FixedArray[0]> [HOLEY_ELEMENTS]
 - properties: 0x024bc0781309 <FixedArray[0]>
 - All own properties (excluding elements): {
    0x24bc07854e1: [String] in ReadOnlySpace: #stack: 0x0e3d7e1412d9 <AccessorInfo> (const accessor descriptor), location: descriptor
    0x24bc0784e41: [String] in ReadOnlySpace: #message: 0x395d9ba45cb9 <String[122]: "Cannot read local builtin. EMFILE: too many open files "/Users/ronagy/GitHub/node/lib/internal/per_context/primordials.js""> (const data field 0), location: in-object
    0x024bc0785b09 <Symbol: (stack_trace_symbol)>: 0x024bc0781309 <FixedArray[0]> (const data field 1), location: in-object
 }
Stack Trace:
=========================================================
0x1f5fa83e6b39: [JS_ERROR_TYPE]
 - map: 0x2206bf9114f9 <Map(HOLEY_ELEMENTS)> [FastProperties]
 - prototype: 0x0cfdbdc077e1 <Object map = 0x2206bf901791>
 - elements: 0x2c488a441309 <FixedArray[0]> [HOLEY_ELEMENTS]
 - properties: 0x2c488a441309 <FixedArray[0]>
 - All own properties (excluding elements): {
    0x2c488a4454e1: [String] in ReadOnlySpace: #stack: 0x1c08316812d9 <AccessorInfo> (const accessor descriptor), location: descriptor
    0x2c488a444e41: [String] in ReadOnlySpace: #message: 0x1f5fa83e6ab1 <String[113]: "Cannot read local builtin. EMFILE: too many open files "/Users/ronagy/GitHub/node/lib/internal/bootstrap/node.js""> (const data field 0), location: in-object
    0x2c488a445b09 <Symbol: (stack_trace_symbol)>: 0x2c488a441309 <FixedArray[0]> (const data field 1), location: in-object
 }
Stack Trace:
=========================================================
0x1ebe441a5da9: [JS_ERROR_TYPE]
 - map: 0x2808670514f9 <Map(HOLEY_ELEMENTS)> [FastProperties]
 - prototype: 0x0a209a8c77e1 <Object map = 0x280867041791>
 - elements: 0x277b60841309 <FixedArray[0]> [HOLEY_ELEMENTS]
 - properties: 0x277b60841309 <FixedArray[0]>
 - All own properties (excluding elements): {
    0x277b608454e1: [String] in ReadOnlySpace: #stack: 0x114f4eb412d9 <AccessorInfo> (const accessor descriptor), location: descriptor
    0x277b60844e41: [String] in ReadOnlySpace: #message: 0x1ebe441a5d21 <String[113]: "Cannot read local builtin. EMFILE: too many open files "/Users/ronagy/GitHub/node/lib/internal/bootstrap/node.js""> (const data field 0), location: in-object
    0x277b60845b09 <Symbol: (stack_trace_symbol)>: 0x277b60841309 <FixedArray[0]> (const data field 1), location: in-object
 }
Stack Trace:
=========================================================
=========================================================
Exception thrown:
0x3ab19f61b2c9: [JS_ERROR_TYPE]
 - map: 0x2bd74a08f459 <Map(HOLEY_ELEMENTS)> [FastProperties]
 - prototype: 0x08b57b4c77e1 <Object map = 0x2bd74a081791>
 - elements: 0x08fe6a1c1309 <FixedArray[0]> [HOLEY_ELEMENTS]
 - properties: 0x08fe6a1c1309 <FixedArray[0]>
 - All own properties (excluding elements): {
    0x8fe6a1c54e1: [String] in ReadOnlySpace: #stack: 0x2d4b287c12d9 <AccessorInfo> (const accessor descriptor), location: descriptor
    0x8fe6a1c4e41: [String] in ReadOnlySpace: #message: 0x3ab19f61b239 <String[123]: "Cannot read local builtin. EMFILE: too many open files "/Users/ronagy/GitHub/node/lib/internal/per_context/domexception.js""> (const data field 0), location: in-object
    0x08fe6a1c5b09 <Symbol: (stack_trace_symbol)>: 0x08fe6a1c1309 <FixedArray[0]> (const data field 1), location: in-object
 }
Stack Trace:
=========================================================
0x1ee41df1b2c9: [JS_ERROR_TYPE]
 - map: 0x248dc560f459 <Map(HOLEY_ELEMENTS)> [FastProperties]
 - prototype: 0x2ca6e0e477e1 <Object map = 0x248dc5601791>
 - elements: 0x2248a0481309 <FixedArray[0]> [HOLEY_ELEMENTS]
 - properties: 0x2248a0481309 <FixedArray[0]>
 - All own properties (excluding elements): {
    0x2248a04854e1: [String] in ReadOnlySpace: #stack: 0x058c6b4012d9 <AccessorInfo> (const accessor descriptor), location: descriptor
    0x2248a0484e41: [String] in ReadOnlySpace: #message: 0x1ee41df1b239 <String[123]: "Cannot read local builtin. EMFILE: too many open files "/Users/ronagy/GitHub/node/lib/internal/per_context/domexception.js""> (const data field 0), location: in-object
    0x2248a0485b09 <Symbol: (stack_trace_symbol)>: 0x2248a0481309 <FixedArray[0]> (const data field 1), location: in-object
 }
Stack Trace:
=========================================================
0x3d54a76a5da9: [JS_ERROR_TYPE]
 - map: 0x3eed611d14f9 <Map(HOLEY_ELEMENTS)> [FastProperties]
 - prototype: 0x1525464c77e1 <Object map = 0x3eed611c1791>
 - elements: 0x3f5fdfc81309 <FixedArray[0]> [HOLEY_ELEMENTS]
 - properties: 0x3f5fdfc81309 <FixedArray[0]>
 - All own properties (excluding elements): {
    0x3f5fdfc854e1: [String] in ReadOnlySpace: 

child stderr: /Users/ronagy/GitHub/node/out/Release/node[97704]: ../../src/node_worker.cc:317:void node::worker::Worker::Run(): Assertion `(env_) != nullptr' failed.
 1: 0x102ba8608 node::Abort() [/Users/ronagy/GitHub/node/out/Release/node]
 2: 0x102ba8450 node::AppendExceptionLine(node::Environment*, v8::Local<v8::Value>, v8::Local<v8::Message>, node::ErrorHandlingMode) [/Users/ronagy/GitHub/node/out/Release/node]
/Users/ronagy/GitHub/node/out/Release/node[97704]: ../../src/node_worker.cc:317:void node::worker::Worker::Run(): Assertion `(env_) != nullptr' failed.
/Users/ronagy/GitHub/node/out/Release/node[97704]: ../../src/node_worker.cc:317:void node::worker::Worker::Run(): Assertion `(env_) != nullptr' failed.
 3: 0x102c399d8 node::worker::Worker::Run() [/Users/ronagy/GitHub/node/out/Release/node]
 1: 0x102ba8608 node::Abort() [/Users/ronagy/GitHub/node/out/Release/node]
 1: 0x102ba8608 node::Abort() [/Users/ronagy/GitHub/node/out/Release/node]
 2: 0x102ba8450 node::AppendExceptionLine(node::Environment*, v8::Local<v8::Value>, v8::Local<v8::Message>, node::ErrorHandlingMode) [/Users/ronagy/GitHub/node/out/Release/node]
 2: 0x102ba8450 node::AppendExceptionLine(node::Environment*, v8::Local<v8::Value>, v8::Local<v8::Message>, node::ErrorHandlingMode) [/Users/ronagy/GitHub/node/out/Release/node]
/Users/ronagy/GitHub/node/out/Release/node[97704]: ../../src/node_worker.cc:317:void node::worker::Worker::Run(): Assertion `(env_) != nullptr' failed.
 3: 0x102c399d8 node::worker::Worker::Run() [/Users/ronagy/GitHub/node/out/Release/node]
 4: 0x102c3ca58 node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::__invoke(void*) [/Users/ronagy/GitHub/node/out/Release/node]
 3: 0x102c399d8 node::worker::Worker::Run() [/Users/ronagy/GitHub/node/out/Release/node]
/Users/ronagy/GitHub/node/out/Release/node[97704]: ../../src/node_worker.cc:317:void node::worker::Worker::Run(): Assertion `(env_) != nullptr' failed.
 1: 0x102ba8608 node::Abort() [/Users/ronagy/GitHub/node/out/Release/node]
 4: 0x102c3ca58 node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::__invoke(void*) [/Users/ronagy/GitHub/node/out/Release/node]
 5: 0x18c7894ec _pthread_start [/usr/lib/system/libsystem_pthread.dylib]
 6: 0x18c7842d0 thread_start [/usr/lib/system/libsystem_pthread.dylib]
 4: 0x102c3ca58 node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::__invoke(void*) [/Users/ronagy/GitHub/node/out/Release/node]
 5: 0x18c7894ec _pthread_start [/usr/lib/system/libsystem_pthread.dylib]
 6: 0x18c7842d0 thread_start [/usr/lib/system/libsystem_pthread.dylib]
/bin/sh: line 1: 97704 Abort trap: 6           /Users/ronagy/GitHub/node/out/Release/node --print-all-exceptions /Users/ronagy/GitHub/node/test/parallel/test-worker-init-failure.js child


node:assert:123
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

134 !== 0

    at ChildProcess.<anonymous> (/Users/ronagy/GitHub/node/test/parallel/test-worker-init-failure.js:65:12)
    at ChildProcess.<anonymous> (/Users/ronagy/GitHub/node/test/common/index.js:401:15)
    at ChildProcess.emit (node:events:390:28)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:290:12) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 134,
  expected: 0,
  operator: 'strictEqual'
}

Node.js v18.0.0-pre

@addaleax
Copy link
Member

Cannot read local builtin leads me to believe that you’re compiling with ./configure --node-builtin-modules-path? Does it also happen for you without?

@ronag
Copy link
Member Author

ronag commented Nov 19, 2021

It doesn't happen without 🎉

@ronag ronag closed this as completed Nov 19, 2021
@GeoffreyBooth
Copy link
Member

I’ve been getting this error for years and finally I searched for it, and found this issue. I don’t think we should close this; it should be possible to run the tests with ./configure --node-builtin-modules-path and not have this test fail.

With ./configure --ninja --node-builtin-modules-path $(pwd) && JOBS=8 make, when running out/Release/node /Users/Geoffrey/Sites/node/test/parallel/test-worker-init-failure.js I get this:

child stdout:

child stderr: /Users/Geoffrey/Sites/node/out/Release/node[38018]: ../../src/node_worker.cc:332:void node::worker::Worker::Run(): Assertion `(env_) != nullptr' failed.
/Users/Geoffrey/Sites/node/out/Release/node[38018]: ../../src/node_worker.cc:332:void node::worker::Worker::Run(): Assertion `(env_) != nullptr' failed.
 1: 0x10b236a95 node::Abort() [/Users/Geoffrey/Sites/node/out/Release/node]
 2: 0x10b2368b1 node::Assert(node::AssertionInfo const&) [/Users/Geoffrey/Sites/node/out/Release/node]
/Users/Geoffrey/Sites/node/out/Release/node[38018]: ../../src/node_worker.cc:332:void node::worker::Worker::Run(): Assertion `(env_) != nullptr' failed.
/Users/Geoffrey/Sites/node/out/Release/node[38018]: ../../src/node_worker.cc:332:void node::worker::Worker::Run(): Assertion `(env_) != nullptr' failed.
/Users/Geoffrey/Sites/node/out/Release/node[38018]: ../../src/node_worker.cc:332:void node::worker::Worker::Run(): Assertion `(env_) != nullptr' failed.
 1: 0x10b236a95 node::Abort() [/Users/Geoffrey/Sites/node/out/Release/node]
node:internal/bootstrap/loaders:327
      const fn = compileFunction(id);
                 ^

Error: Cannot read local builtin. EMFILE: too many open files "/Users/Geoffrey/Sites/node/lib/internal/errors.js"

Node.js v19.0.0-pre
/Users/Geoffrey/Sites/node/out/Release/node[38018]: ../../src/node_platform.cc:281:virtual node::PerIsolatePlatformData::~PerIsolatePlatformData(): Assertion `!flush_tasks_' failed.
 3: 0x10b2dbe5d node::worker::Worker::Run() [/Users/Geoffrey/Sites/node/out/Release/node]
 1: 0x10b236a95 node::Abort() [/Users/Geoffrey/Sites/node/out/Release/node]
 1: 0x10b236a95 node::Abort() [/Users/Geoffrey/Sites/node/out/Release/node]
 1: 0x10b236a95 node::Abort() [/Users/Geoffrey/Sites/node/out/Release/node]
 2: 0x10b2368b1 node::Assert(node::AssertionInfo const&) [/Users/Geoffrey/Sites/node/out/Release/node]
 1: 0x10b236a95 node::Abort() [/Users/Geoffrey/Sites/node/out/Release/node]
 4: 0x10b2df692 node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::__invoke(void*) [/Users/Geoffrey/Sites/node/out/Release/node]
 2: 0x10b2368b1 node::Assert(node::AssertionInfo const&) [/Users/Geoffrey/Sites/node/out/Release/node]
 2: 0x10b2368b1 node::Assert(node::AssertionInfo const&) [/Users/Geoffrey/Sites/node/out/Release/node]
 2: 0x10b2368b1 node::Assert(node::AssertionInfo const&) [/Users/Geoffrey/Sites/node/out/Release/node]
 3: 0x10b2dbe5d node::worker::Worker::Run() [/Users/Geoffrey/Sites/node/out/Release/node]
 2: 0x10b2368b1 node::Assert(node::AssertionInfo const&) [/Users/Geoffrey/Sites/node/out/Release/node]
 5: 0x7fff203d98fc _pthread_start [/usr/lib/system/libsystem_pthread.dylib]
 3: 0x10b2a20b3 node::PerIsolatePlatformData::~PerIsolatePlatformData() [/Users/Geoffrey/Sites/node/out/Release/node]
 3: 0x10b2dbe5d node::worker::Worker::Run() [/Users/Geoffrey/Sites/node/out/Release/node]
 3: 0x10b2dbe5d node::worker::Worker::Run() [/Users/Geoffrey/Sites/node/out/Release/node]
 4: 0x10b2df692 node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::__invoke(void*) [/Users/Geoffrey/Sites/node/out/Release/node]
 3: 0x10b2dbe5d node::worker::Worker::Run() [/Users/Geoffrey/Sites/node/out/Release/node]
 6: 0x7fff203d5443 thread_start [/usr/lib/system/libsystem_pthread.dylib]
/bin/sh: line 1: 38018 Abort trap: 6           /Users/Geoffrey/Sites/node/out/Release/node /Users/Geoffrey/Sites/node/test/parallel/test-worker-init-failure.js child


node:assert:123
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

134 !== 0

    at ChildProcess.<anonymous> (/Users/Geoffrey/Sites/node/test/parallel/test-worker-init-failure.js:65:12)
    at ChildProcess.<anonymous> (/Users/Geoffrey/Sites/node/test/common/index.js:438:15)
    at ChildProcess.emit (node:events:527:28)
    at ChildProcess._handle.onexit (node:internal/child_process:291:12) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 134,
  expected: 0,
  operator: 'strictEqual'
}

Node.js v19.0.0-pre

So from the looks of it, --node-builtin-modules-path causes Node to load too many files for this test to pass. Can we simply skip this test when Node is running in --node-builtin-modules-path mode? The test is already skipped on Windows; and since I doubt we run in --node-builtin-modules-path mode in CI, having it skip when --node-builtin-modules-path is used will fix local development with no real other effect. cc @Trott @addaleax

@GeoffreyBooth GeoffreyBooth reopened this Apr 21, 2022
@GeoffreyBooth GeoffreyBooth changed the title Worker assertion Test failure in test-worker-init-failure.js when running with --node-builtin-modules-path Apr 21, 2022
@GeoffreyBooth GeoffreyBooth mentioned this issue Apr 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: skip test that cannot pass under --node-builtin-modules-path GeoffreyBooth/node
3 participants
@GeoffreyBooth @addaleax @ronag