Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intl.datetimeformat comma removed after version 20.11.1 #53083

Closed
dgabrielm opened this issue May 21, 2024 · 8 comments
Closed

intl.datetimeformat comma removed after version 20.11.1 #53083

dgabrielm opened this issue May 21, 2024 · 8 comments
Labels
i18n-api Issues and PRs related to the i18n implementation. wontfix Issues that will not be fixed.

Comments

@dgabrielm
Copy link

Version

20.11.2+

Platform

Darwin Darios-MacBook-Pro.local 22.6.0 Darwin Kernel Version 22.6.0: Wed Oct 4 21:25:26 PDT 2023; root:xnu-8796.141.3.701.17~4/RELEASE_X86_64 x86_64

Subsystem

intl.datetimeformate

What steps will reproduce the bug?

open terminal
confirm node version is above 20.11.1
node
node interface runs
d = new Date(Date.now())
formatted = new Intl.DateTimeFormat('en-GB', { dateStyle: 'full', timeStyle: 'medium' }).format(d)

output will show date string e.g. 'Tuesday 21 May 2024 at 09:55:02' with missing comma

If you repeat the process with 20.11.1 or below the output will be with a comma e.g. 'Tuesday, 21 May 2024 at 09:55:02'

How often does it reproduce? Is there a required condition?

every time

What is the expected behavior? Why is that the expected behavior?

output of formatted date should be (example) 'Tuesday, 21 May 2024 at 09:55:02'

What do you see instead?

I see instead (example) 'Tuesday 21 May 2024 at 09:55:02'

Additional information

No response

@RedYetiDev
Copy link
Member

IIRC The I18N data is updated for every version, and compatibility isn't guaranteed

I might be wrong, cc @nodejs/i18n

@RedYetiDev RedYetiDev added the i18n-api Issues and PRs related to the i18n implementation. label May 21, 2024
@ovflowd
Copy link
Member

ovflowd commented May 21, 2024

IIRC The I18N data is updated for every version, and compatibility isn't guaranteed

I might be wrong, cc @nodejs/i18n

The @nodejs/i18n team is not responsible for this; the @nodejs/i18n-api is responsible for Node.js Core i18n APIs, afaik.

@RedYetiDev
Copy link
Member

My bad, sorry. I looked for i18n in the team list.

@ovflowd
Copy link
Member

ovflowd commented May 22, 2024

My bad, sorry. I looked for i18n in the team list.

All good, but I believe you're pretty on point with your explanation. I don't think this is a Node.js bug, but just a side-effect of the i18n data that comes with V8 (I believe that's where our Intl. APIs come from, including the i18n data for those APIs), I believe that the TextEncoder ones and others, come from Node.js itself.

@targos
Copy link
Member

targos commented May 22, 2024

More specifically, the data comes from ICU (a dependency of V8).

@srl295
Copy link
Member

srl295 commented May 23, 2024

More specifically, the data comes from ICU (a dependency of V8).

even more specifically, ICU's data comes from cldr, a dependency of ICU

@RedYetiDev RedYetiDev added wontfix Issues that will not be fixed. labels May 24, 2024
@RedYetiDev
Copy link
Member

Is wontfix appropiate here? (Working as Intended)

@RedYetiDev
Copy link
Member

Thanks for issue, I'm closing this as the feature is working as intended. If you disagree, please leave a comment.

@RedYetiDev RedYetiDev closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-api Issues and PRs related to the i18n implementation. wontfix Issues that will not be fixed.
Projects
None yet
Development

No branches or pull requests

5 participants