diff --git a/deps/v8/include/v8-version.h b/deps/v8/include/v8-version.h index 2cc9821769a586..ac423bf90ec201 100644 --- a/deps/v8/include/v8-version.h +++ b/deps/v8/include/v8-version.h @@ -11,7 +11,7 @@ #define V8_MAJOR_VERSION 5 #define V8_MINOR_VERSION 8 #define V8_BUILD_NUMBER 283 -#define V8_PATCH_LEVEL 38 +#define V8_PATCH_LEVEL 39 // Use 1 for candidates and 0 otherwise. // (Boolean macro values are not supported by all preprocessors.) diff --git a/deps/v8/include/v8.h b/deps/v8/include/v8.h index baf44170f03d07..e38f657b48fae8 100644 --- a/deps/v8/include/v8.h +++ b/deps/v8/include/v8.h @@ -7982,6 +7982,11 @@ class V8_EXPORT TryCatch { */ void SetVerbose(bool value); + /** + * Returns true if verbosity is enabled. + */ + bool IsVerbose() const; + /** * Set whether or not this TryCatch should capture a Message object * which holds source information about where the exception diff --git a/deps/v8/src/api.cc b/deps/v8/src/api.cc index 8ede1071d6a7fb..8ce75201c2f695 100644 --- a/deps/v8/src/api.cc +++ b/deps/v8/src/api.cc @@ -2691,6 +2691,10 @@ void v8::TryCatch::SetVerbose(bool value) { is_verbose_ = value; } +bool v8::TryCatch::IsVerbose() const { + return is_verbose_; +} + void v8::TryCatch::SetCaptureMessage(bool value) { capture_message_ = value; diff --git a/src/node.cc b/src/node.cc index 770c68d57520d6..11d9b51d89e76f 100644 --- a/src/node.cc +++ b/src/node.cc @@ -2648,9 +2648,9 @@ void FatalException(Isolate* isolate, void FatalException(Isolate* isolate, const TryCatch& try_catch) { HandleScope scope(isolate); - // TODO(bajtos) do not call FatalException if try_catch is verbose - // (requires V8 API to expose getter for try_catch.is_verbose_) - FatalException(isolate, try_catch.Exception(), try_catch.Message()); + if (!try_catch.IsVerbose()) { + FatalException(isolate, try_catch.Exception(), try_catch.Message()); + } }