From 0b1d2fed768bdb9e0061847a0dd648a41fdebdcf Mon Sep 17 00:00:00 2001 From: Tanuja-Sawant Date: Sun, 9 Oct 2016 15:06:38 +0530 Subject: [PATCH 1/2] lib: update outdated comment --- lib/child_process.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/child_process.js b/lib/child_process.js index a7815ac85c3bbf..4e2344e89791d3 100644 --- a/lib/child_process.js +++ b/lib/child_process.js @@ -50,8 +50,8 @@ exports.fork = function(modulePath /*, args, options*/) { args = execArgv.concat([modulePath], args); if (!Array.isArray(options.stdio)) { - // Leave stdin open for the IPC channel. stdout and stderr should be the - // same as the parent's if silent isn't set. + // Use a separate fd=3 for IPC channel. Inherit stdin, stdout, and stderr + // from the parent if silent isn't set. options.stdio = options.silent ? ['pipe', 'pipe', 'pipe', 'ipc'] : [0, 1, 2, 'ipc']; } else if (options.stdio.indexOf('ipc') === -1) { From 78ab70a5799895e05a06fe65052349d50762c2ef Mon Sep 17 00:00:00 2001 From: Tanuja-Sawant Date: Sun, 9 Oct 2016 23:47:41 +0530 Subject: [PATCH 2/2] lib: update outdated comment --- lib/child_process.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/child_process.js b/lib/child_process.js index 4e2344e89791d3..b3f92ad9304be3 100644 --- a/lib/child_process.js +++ b/lib/child_process.js @@ -50,7 +50,7 @@ exports.fork = function(modulePath /*, args, options*/) { args = execArgv.concat([modulePath], args); if (!Array.isArray(options.stdio)) { - // Use a separate fd=3 for IPC channel. Inherit stdin, stdout, and stderr + // Use a separate fd=3 for the IPC channel. Inherit stdin, stdout, and stderr // from the parent if silent isn't set. options.stdio = options.silent ? ['pipe', 'pipe', 'pipe', 'ipc'] : [0, 1, 2, 'ipc'];