Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudflare caching 500 responses #5818

Closed
broksonic21 opened this issue Sep 20, 2023 · 10 comments
Closed

Cloudflare caching 500 responses #5818

broksonic21 opened this issue Sep 20, 2023 · 10 comments
Labels

Comments

@broksonic21
Copy link

URL:

https://nodejs.org/dist/v18.17.1/node-v18.17.1-darwin-arm64.tar.gz

Browser Name:

any http call

Browser Version:

any http call

Operating System:

any http call

How to reproduce the issue:

curl -I https://nodejs.org/dist/v18.17.1/node-v18.17.1-darwin-arm64.tar.gz
HTTP/2 500
date: Wed, 20 Sep 2023 17:19:43 GMT
content-type: text/html
cf-cache-status: HIT
strict-transport-security: max-age=31536000; includeSubDomains; preload
x-content-type-options: nosniff
server: cloudflare

See that it's a HIT --- Looks like Cloudflare is configured to cache 500 responses. It goes away eventually if you retry, but this causes install issues across the ecosystem. Can this be changed to not cache so it gets to 200s easier

@bmuenzenmeyer
Copy link
Collaborator

@ovflowd or anyone on @nodejs/web-infra with cloudflare access - can you look into this?

@ovflowd
Copy link
Member

ovflowd commented Sep 21, 2023

We are aware of this. There is an issue already with this. I've been waiting the @nodejs/build WG to work on this for a month for now nodejs/build#3473

cc @richardlau or @Trott if for god sake someone could pretty please take care of this little task

@Trott
Copy link
Member

Trott commented Sep 21, 2023

cc @richardlau or @Trott if for god sake someone could pretty please take care of this little task

I don't have access to Cloudflare so I can't do it. I left another comment on the issue, though....

@ovflowd
Copy link
Member

ovflowd commented Sep 21, 2023

cc @richardlau or @Trott if for god sake someone could pretty please take care of this little task

I don't have access to Cloudflare so I can't do it. I left another comment on the issue, though....

Sorry, I forgot you don't have 🫠

@MattIPv4
Copy link
Member

Should we open an issue with the build WG to look at getting web infra folks full access to Cloudflare? I'm not sure what the build WG process is for making Cf changes at the moment, but it seems like it is incredibly slow, resulting in a poor experience for users, and the web infra team can't really do anything to fix it...

@ovflowd
Copy link
Member

ovflowd commented Sep 21, 2023

I think we should open an issue on the admin repo, as we should request the TSC to properly delegate access officially to the web-infra to such resources.

Otherwise we will forever depend on the build WG.

@MattIPv4 if you can open the issue, that'd be great!

Because pretty much that would require the TSC to delegate access, but the tricky part is that the Build WG already has ownership of that. So we need to figure that out.

@targos
Copy link
Member

targos commented Sep 21, 2023

I'm sorry if I looked like someone selfish/not collaborative, but this request came during a long awaited period of holiday for me, where I tried to disconnect as much as possible, and the recurrent pings (especially on Slack) made me stop looking at everything. I'm slowly coming back but have a huge backlog now. This issue is in my saved notifications and I hope to come back to it in a few days.

@ovflowd
Copy link
Member

ovflowd commented Sep 21, 2023

I'm sorry if I looked like someone selfish/not collaborative, but this request came during a long awaited period of holiday for me, where I tried to disconnect as much as possible, and the recurrent pings (especially on Slack) made me stop looking at everything. I'm slowly coming back but have a huge backlog now. This issue is in my saved notifications and I hope to come back to it in a few days.

No worries @targos, being frank, I am aware that the Build WG has a lot on its plate, even more with the macOS stuff right now, but I was worried that somehow I did something wrong and lost the trust of the Build WG. I know I've been nagging, and I'm so sorry for the immense amount of pings.

@MattIPv4
Copy link
Member

I've filed nodejs/admin#833 to explore expanding Cloudflare access, so that web-infra could handle changes directly without having to add more work to the build WG's plate.

@ovflowd
Copy link
Member

ovflowd commented Sep 29, 2023

These changes got deployed. Cloudflare should not be caching anymore 5XXs.

@ovflowd ovflowd closed this as completed Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants