Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] NPM install fails when using node 22.5.0 #7663

Closed
2 tasks done
gabriel-piltzer-trimble opened this issue Jul 18, 2024 · 1 comment
Closed
2 tasks done

[BUG] NPM install fails when using node 22.5.0 #7663

gabriel-piltzer-trimble opened this issue Jul 18, 2024 · 1 comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps

Comments

@gabriel-piltzer-trimble
Copy link

gabriel-piltzer-trimble commented Jul 18, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Whoops just found the existing issue. Closing this one.

This issue exists in the latest npm version

  • I am using the latest npm

Current Behavior

This GitHub workflow is failing. The lint step should run eslint. I believe this is broken by node 22.5.0. If I lock the node-version to 22.1.0 it runs without error.

name: PR Checks

on:
  pull_request:
    branches:
      - main
    types: [opened, synchronize]

jobs:
  pr_checks:
    name: PR Checks
    runs-on: ubuntu-latest

    steps:
      - name: Checkout code
        uses: actions/checkout@v2

      - name: Set up Node.js
        uses: actions/setup-node@v2
        with:
          node-version: '22'

      - name: Install dependencies
        run: npm ci

      - name: Lint code
        run: npm run lint
        continue-on-error: false

GitHub action output (log):

Set up job

Current runner version: '2.317.0'
Operating System
  Ubuntu
  [2](https://github.com/Trimble-Construction/prism-ui-common/actions/runs/9994428986/job/27624176165#step:1:2)2.04.4
  LTS
Runner Image
  Image: ubuntu-22.04
  Version: 20240714.1.0
  Included Software: https://github.com/actions/runner-images/blob/ubuntu22/20240714.1/images/ubuntu/Ubuntu2204-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20240714.1
Runner Image Provisioner
GITHUB_TOKEN Permissions
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v2' (SHA:ee0669bd1cc54295c22[3](https://github.com/Trimble-Construction/prism-ui-common/actions/runs/9994428986/job/27624176165#step:1:3)e0bb666b733df[4](https://github.com/Trimble-Construction/prism-ui-common/actions/runs/9994428986/job/27624176165#step:1:4)1de1c5)
Download action repository 'actions/setup-node@v2' (SHA:7c12f8017d[5](https://github.com/Trimble-Construction/prism-ui-common/actions/runs/9994428986/job/27624176165#step:1:5)436eb855f1ed4399f037a3[6](https://github.com/Trimble-Construction/prism-ui-common/actions/runs/9994428986/job/27624176165#step:1:7)fbd9e8)
Complete job name: PR Checks

Set up Node.js

Run actions/setup-node@v2
  with:
    node-version: [2](https://github.com/Trimble-Construction/prism-ui-common/actions/runs/9994428986/job/27624176165#step:3:2)2
    always-auth: false
    check-latest: false
    token: ***
Attempting to download 22...
Acquiring 22.5.0 - x64 from https://github.com/actions/node-versions/releases/download/22.5.0-998514410[3](https://github.com/Trimble-Construction/prism-ui-common/actions/runs/9994428986/job/27624176165#step:3:3)/node-22.5.0-linux-x6[4](https://github.com/Trimble-Construction/prism-ui-common/actions/runs/9994428986/job/27624176165#step:3:4).tar.gz
Extracting ...
/usr/bin/tar xz --strip 1 --warning=no-unknown-keyword --overwrite -C /home/runner/work/_temp/7024a[5](https://github.com/Trimble-Construction/prism-ui-common/actions/runs/9994428986/job/27624176165#step:3:5)04-ef91-4589-a9b3-578bc07ad08c -f /home/runner/work/_temp/f93397b8-99[6](https://github.com/Trimble-Construction/prism-ui-common/actions/runs/9994428986/job/27624176165#step:3:6)2-4df3-8682-c8046b46bb88
Adding to the cache ...
Done

Install dependencies

##[debug]Evaluating condition for step: 'Install dependencies'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Install dependencies
##[debug]Loading inputs
##[debug]Loading env
Run npm ci
##[debug]/usr/bin/bash -e /home/runner/work/_temp/47[2](https://github.com/Trimble-Construction/prism-ui-common/actions/runs/9994276674/job/27623701138#step:4:2)dbcba-1c87-4079-b1ee-d9ea5fa4af82.sh
npm warn deprecated domexception@4.0.0: Use your platform's native DOMException instead
npm warn deprecated abab@2.0.6: Use your platform's native atob() and btoa() methods instead
npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error   <https://github.com/npm/cli/issues>
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-07-18T15_24_[3](https://github.com/Trimble-Construction/prism-ui-common/actions/runs/9994276674/job/27623701138#step:4:3)7_103Z-debug-0.log
##[debug]Finishing: Install dependencies

Lint code

Run npm run lint

> @trimble-cms/prism-ui-common@1.0.0-beta.32 lint
> eslint

sh: 1: eslint: not found
Error: Process completed with exit code 12[7](https://github.com/Trimble-Construction/prism-ui-common/actions/runs/9994428986/job/27624176165#step:5:8).

Expected Behavior

npm install and npm ci should run without error

Steps To Reproduce

  1. Create a project that uses eslint
  2. Create a GitHub workflow like the one in the "Current Behavior" section
  3. Create a PR and watch the action run and fail trying to install dependencies

Environment

  • npm: 10.8.2
  • Node.js: 22.5.0
  • OS Name: Ubuntu 22.04.4
  • System Model Name:
  • npm config:
; copy and paste output from `npm config ls` here
@gabriel-piltzer-trimble gabriel-piltzer-trimble added Bug thing that needs fixing Needs Triage needs review for next steps labels Jul 18, 2024
@gabriel-piltzer-trimble
Copy link
Author

gabriel-piltzer-trimble commented Jul 18, 2024

Found this existing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps
Projects
None yet
Development

No branches or pull requests

1 participant