Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Less settings than before? #602

Closed
dantahoua opened this issue Dec 10, 2015 · 7 comments
Closed

Less settings than before? #602

dantahoua opened this issue Dec 10, 2015 · 7 comments

Comments

@dantahoua
Copy link
Contributor

Is it me or we have less settings possibility in the setting.scss? I want to change the burger icon color, I want it black hover white but I can't find any place to change that...
The class is menu-icon::after...
Anyway I will change it in my custom scss, but it'll add some line to the css...

@colin-marshall
Copy link
Collaborator

There are less settings in Foundation 6. This was to make the framework be less opinionated in styling. The hamburger icon setting was not in F6 at first and then it was added in this commit: foundation/foundation-sites@573e933

The setting you want to use is $titlebar-icon-color.

Here is the issue discussing that commit: foundation/foundation-sites#7294

@dantahoua
Copy link
Contributor Author

Ok, so if I want to change this without adding too much stuff I can declare $titlebar-icon-color in the setting.scss of my theme?
Anyway I ended up changing too much stuff on the burger icon but for the next time I would like to know the best way to go... :)

@colin-marshall
Copy link
Collaborator

They're already in the FP settings file:
https://github.com/olefredrik/FoundationPress/blob/master/assets/scss/global/_settings.scss

Go to the very last section.

@dantahoua
Copy link
Contributor Author

No they aren't! Or I need new glasses! :) No $titlebar-icon-color in the last section (which is a section about the topbar ) or before (section 31 is about tabbar). Anyway I think we must concentrate before on typekit, image (with wp 4.4) small bugs before those little stuff! :) As I'am using the theme for a new production I'll try to test as much as possible.

@Aetles
Copy link
Contributor

Aetles commented Dec 11, 2015

They clearly are not there. But I assume they will be once FP is upgraded to Foundation 6.0.5.

@colin-marshall
Copy link
Collaborator

My bad I was looking at the wrong file. I'll make a PR to fix this in a bit.

@olefredrik
Copy link
Owner

Settings file is updated to v6.0.5 #612

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants