Operator: service reconciliation error

[frzifus]

Component(s)

collector

What happened?

Description

Spam of operator error logs

Steps to Reproduce

• Install the OpenTelemetry collector built off the latest upstream branch.
• Create a OpenTelemetry collector with OTLP grpc and http receiver.
• Check the created servcies with oc get svc and check the operator logs.
• You can also create the resources by following the steps from this test case. https://github.com/open-telemetry/opentelemetry-operator/tree/main/tests/e2e-openshift/otlp-metrics-traces

Expected Result

NAME                                     TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)                                                              AGE
cluster-collector-collector              ClusterIP   172.30.165.115   <none>        4317/TCP,4318/TCP,8889/TCP                                           5s
cluster-collector-collector-headless     ClusterIP   None             <none>        4317/TCP,4318/TCP,8889/TCP                                           5s
cluster-collector-collector-monitoring   ClusterIP   172.30.234.38    <none>        8888/TCP  

Actual Result

Operator Logs

{
  "level": "ERROR",
  "timestamp": "2024-07-13T14:05:31.962191926Z",
  "logger": "controllers.OpenTelemetryCollector",
  "message": "failed to configure desired",
  "opentelemetrycollector": {
    "name": "cluster-collector",
    "namespace": "chainsaw-otlp-metrics"
  },
  "object_name": "cluster-collector-collector-headless",
  "object_kind": "&TypeMeta{Kind:,APIVersion:,}",
  "error": "Service \"cluster-collector-collector-headless\" is invalid: spec.ports[1]: Duplicate value: core.ServicePort{Name:\"\", Protocol:\"TCP\", AppProtocol:(*string)(nil), Port:4317, TargetPort:intstr.IntOrString{Type:0, IntVal:0, StrVal:\"\"}, NodePort:0}",
  "stacktrace": "github.com/open-telemetry/opentelemetry-operator/controllers.reconcileDesiredObjects\n\t/var/home/frzifus/git/go/observability/opentelemetry-operator/controllers/common.go:166\ngithub.com/open-telemetry/opentelemetry-operator/controllers.(*OpenTelemetryCollectorReconciler).Reconcile\n\t/var/home/frzifus/git/go/observability/opentelemetry-operator/controllers/opentelemetrycollector_controller.go:286\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/var/home/frzifus/git/golang_workspace/pkg/mod/sigs.k8s.io/controller-runtime@v0.18.4/pkg/internal/controller/controller.go:114\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/var/home/frzifus/git/golang_workspace/pkg/mod/sigs.k8s.io/controller-runtime@v0.18.4/pkg/internal/controller/controller.go:311\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/var/home/frzifus/git/golang_workspace/pkg/mod/sigs.k8s.io/controller-runtime@v0.18.4/pkg/internal/controller/controller.go:261\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/var/home/frzifus/git/golang_workspace/pkg/mod/sigs.k8s.io/controller-runtime@v0.18.4/pkg/internal/controller/controller.go:222"
}

Kubernetes Version

1.26

Operator version

0cafedf

Collector version

v0.103.0

Environment information

Environment

OS: Fedora Silverblue
Compiler(if manually compiled): go version go1.22.2 linux/amd64

Log output

No response

Additional context

I assume it was introduced here: 1289c63

Reverting this change, resolves the issue.

---

Original report:
https://issues.redhat.com/browse/TRACING-4458

[jaronoff97]

@frzifus i'm looking into this rn too