Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test case src/autoval_ssd/tests/nvme_cli/nvme_cli.py _validate_capacity(function) check support_dev_self_test_management have issue #3

Open
kwzhu123 opened this issue Jun 18, 2024 · 4 comments

Comments

@kwzhu123
Copy link

kwzhu123 commented Jun 18, 2024

1.test case src/autoval_ssd/tests/nvme_cli/nvme_cli.py
2.function[_validate_capacity] check namespace_management capacity used bit 4, should use bit 3
oacs = NVMeUtils.get_id_ctrl(self.host, drive.block_name)["oacs"]
support_namespace_management = oacs & 0x8
AutovalUtils.validate_condition(
support_namespace_management and 0x8,

3.NVMe SPEc ExpressTM Revision 1.4
Bit 4 if set to ‘1’, then the controller supports the Device Self-test command. If cleared
to ‘0’, then the controller does not support the Device Self-test command.

Bit 3 if set to ‘1’, then the controller supports the Namespace Management capability
(refer to section 8.12). If cleared to ‘0’, then the controller does not support the
Namespace Management capability.

@jackeichen
Copy link

Bit X is 0 based index, and 0x08 means 0000 1000b. So I think it works well here.

@kwzhu123
Copy link
Author

def _check_oacs_device_self_test(self, drive) -> None:
support_dev_self_test_management = oacs & 0x8 #check self test used 0x8 too, should be 0x10?

def _validate_capacity(self, drive) -> None:
support_namespace_management = oacs & 0x8

@jackeichen
Copy link

def _check_oacs_device_self_test(self, drive) -> None: support_dev_self_test_management = oacs & 0x8 #check self test used 0x8 too, should be 0x10?

def _validate_capacity(self, drive) -> None: support_namespace_management = oacs & 0x8

It should be a mistake here.

@kwzhu123 kwzhu123 changed the title test case src/autoval_ssd/tests/nvme_cli/nvme_cli.py _validate_capacity(function) check namespace_management capacity have issue test case src/autoval_ssd/tests/nvme_cli/nvme_cli.py _validate_capacity(function) check support_dev_self_test_management have issue Jun 24, 2024
@kwzhu123
Copy link
Author

ok,i modify bug title,help to fix it
support_dev_self_test_management-->0x10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants