Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More granular sync info RPC method #7838

Closed
onbjerg opened this issue Apr 24, 2024 · 6 comments
Closed

More granular sync info RPC method #7838

onbjerg opened this issue Apr 24, 2024 · 6 comments
Assignees
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@onbjerg
Copy link
Member

onbjerg commented Apr 24, 2024

Describe the feature

We should add an endpoint to get more granular syncing info from Reth. It should return:

  • The current checkpoint of each stage in an ordered array of { stage, checkpoint }
  • The current target, e.g. just the latest FCU

Additional context

No response

@onbjerg onbjerg added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Apr 24, 2024
@onbjerg
Copy link
Member Author

onbjerg commented Apr 24, 2024

cc @mattsse unsure if we should just stuff this into the reth_ namespace

@onbjerg onbjerg changed the title Syncing RPC endpoint More granular sync info RPC endpoint Apr 24, 2024
@onbjerg onbjerg changed the title More granular sync info RPC endpoint More granular sync info RPC method Apr 24, 2024
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label May 16, 2024
@Rjected Rjected added D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels May 22, 2024
@mattsse
Copy link
Collaborator

mattsse commented Jun 14, 2024

we should but this under reth_ namespace

we need a few things first

  1. rpc types
  2. rpc module variant
  3. then a handler implementation that monitors engine events

@kunal365roy
Copy link

Hey @mattsse, I'd love to take a stab at this!

@loocapro
Copy link
Contributor

Can I take this?

@mattsse
Copy link
Collaborator

mattsse commented Aug 3, 2024

completed via #10042

@mattsse mattsse closed this as completed Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Archived in project
Development

No branches or pull requests

5 participants