From b37f62dd2bc17ead0c7085b0e3f020c1b9b477c6 Mon Sep 17 00:00:00 2001 From: Mark Althoff Date: Mon, 27 Sep 2021 20:08:29 +0200 Subject: [PATCH 1/3] Fix: Add Promise as return type to save method The types of the jsPDF.save method only mention jsPDF itself, but if returnPromise options is set to true the function returns a promise. --- types/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/index.d.ts b/types/index.d.ts index 8b8c6f70b..c8c6dde0b 100644 --- a/types/index.d.ts +++ b/types/index.d.ts @@ -844,7 +844,7 @@ declare module "jspdf" { ry: number, style?: string | null ): jsPDF; - save(filename?: string, options?: { returnPromise?: boolean }): jsPDF; + save(filename?: string, options?: { returnPromise?: boolean }): jsPDF | Promise; saveGraphicsState(): jsPDF; setCharSpace(charSpace: number): jsPDF; setCreationDate(date?: Date | string): jsPDF; From 23aca37cd0557dc9f140d0e0801983b58df82bc7 Mon Sep 17 00:00:00 2001 From: Uzlopak Date: Tue, 28 Sep 2021 09:56:43 +0200 Subject: [PATCH 2/3] Update index.d.ts --- types/index.d.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/types/index.d.ts b/types/index.d.ts index c8c6dde0b..c0c65dabe 100644 --- a/types/index.d.ts +++ b/types/index.d.ts @@ -843,8 +843,9 @@ declare module "jspdf" { rx: number, ry: number, style?: string | null - ): jsPDF; - save(filename?: string, options?: { returnPromise?: boolean }): jsPDF | Promise; + ): jsPDF;; + save(filename: string, options: { returnPromise: true }): Promise; + save(filename?: string): jsPDF; saveGraphicsState(): jsPDF; setCharSpace(charSpace: number): jsPDF; setCreationDate(date?: Date | string): jsPDF; From 52ea94b0ba8987285a2235f7b716c78e7422da7a Mon Sep 17 00:00:00 2001 From: Uzlopak Date: Tue, 28 Sep 2021 09:58:08 +0200 Subject: [PATCH 3/3] Update index.d.ts --- types/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/index.d.ts b/types/index.d.ts index c0c65dabe..af7f204af 100644 --- a/types/index.d.ts +++ b/types/index.d.ts @@ -843,7 +843,7 @@ declare module "jspdf" { rx: number, ry: number, style?: string | null - ): jsPDF;; + ): jsPDF; save(filename: string, options: { returnPromise: true }): Promise; save(filename?: string): jsPDF; saveGraphicsState(): jsPDF;