Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emails with + in them cannot be used for prospects #35

Closed
ted-hanson opened this issue Jan 4, 2018 · 2 comments · Fixed by #34
Closed

emails with + in them cannot be used for prospects #35

ted-hanson opened this issue Jan 4, 2018 · 2 comments · Fixed by #34

Comments

@ted-hanson
Copy link

ted-hanson commented Jan 4, 2018 •
edited
Loading

When an email with a '+' in it (ie ted+test@test.com) is passed in a prospect request you get the following error:
Pardot::ResponseError: Invalid prospect email address

This is due to the request url with a + not being properly escaped and being sent to the api in the url.
@ted-hanson ted-hanson mentioned this issue Jan 4, 2018
Merged
@brazyi brazyi mentioned this issue May 14, 2018
Closed
@thejosk
Copy link

thejosk commented Aug 14, 2018 •
edited
Loading

Can someone please review and merge this?

@asimon asimon mentioned this issue Mar 6, 2019
Open
@ted-hanson
Copy link
Author

ted-hanson commented Aug 23, 2019 •
edited
Loading

Hey there, would appreciate any feedback that would help this get merged!

Currently having to install the gem from our own github repo here: https://github.com/avochato/ruby-pardot/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ted-hanson @thejosk