Fix transferable balance in api.derive.balances.all with new formula

[TarikGul]

Currently the following code snippet shows that we are using an outdated balance formula for retrieving the transferable balance. Related issue: polkadot-js/apps#9988 (Please see the issue for more detail).

api/packages/api-derive/src/balances/all.ts

Lines 32 to 53 in 6415eb6

	function calcLocked (api: DeriveApi, bestNumber: BlockNumber, locks: (PalletBalancesBalanceLock | BalanceLockTo212)[]): AllLocked {
	let lockedBalance = api.registry.createType('Balance');
	let lockedBreakdown: (PalletBalancesBalanceLock | BalanceLockTo212)[] = [];
	let vestingLocked = api.registry.createType('Balance');
	let allLocked = false;
	if (Array.isArray(locks)) {
	// only get the locks that are valid until passed the current block
	lockedBreakdown = (locks as BalanceLockTo212[]).filter(({ until }): boolean => !until || (bestNumber && until.gt(bestNumber)));
	allLocked = lockedBreakdown.some(({ amount }) => amount && amount.isMax());
	vestingLocked = api.registry.createType('Balance', lockedBreakdown.filter(({ id }) => id.eq(VESTING_ID)).reduce((result: BN, { amount }) => result.iadd(amount), new BN(0)));
	// get the maximum of the locks according to https://github.com/paritytech/substrate/blob/master/srml/balances/src/lib.rs#L699
	const notAll = lockedBreakdown.filter(({ amount }) => amount && !amount.isMax());
	if (notAll.length) {
	lockedBalance = api.registry.createType('Balance', bnMax(...notAll.map(({ amount }): Balance => amount)));
	}
	}
	return { allLocked, lockedBalance, lockedBreakdown, vestingLocked };
	}

api/packages/api-derive/src/balances/all.ts

Lines 55 to 64 in 6415eb6

	function calcShared (api: DeriveApi, bestNumber: BlockNumber, data: DeriveBalancesAccountData, locks: (PalletBalancesBalanceLock | BalanceLockTo212)[]): DeriveBalancesAllAccountData {
	const { allLocked, lockedBalance, lockedBreakdown, vestingLocked } = calcLocked(api, bestNumber, locks);
	return objectSpread({}, data, {
	availableBalance: api.registry.createType('Balance', allLocked ? 0 : bnMax(new BN(0), data?.freeBalance ? data.freeBalance.sub(lockedBalance) : new BN(0))),
	lockedBalance,
	lockedBreakdown,
	vestingLocked
	});
	}

The curent implementation needs to take into account:

https://github.com/paritytech/polkadot-sdk/blob/3069b0af398e5a0374802c31201637e97f4a530a/substrate/frame/balances/src/impl_fungible.rs#L44-L70

[TarikGul]

rel: paritytech/polkadot-sdk#1833

[TarikGul]

This is currently what I am working with: max(free - (frozen - on_hold), free - ED)

[polkadot-js-bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.