Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration to disable query batching #23730

Open
janpio opened this issue Apr 4, 2024 · 2 comments
Open

Add configuration to disable query batching #23730

janpio opened this issue Apr 4, 2024 · 2 comments
Labels
domain/client Issue in the "Client" domain: Prisma Client, Prisma Studio etc. kind/feature A request for a new feature. topic: batching topic: client api topic: performance

Comments

@janpio
Copy link
Contributor

janpio commented Apr 4, 2024 •
edited
Loading

Sometimes our batching functionality (see https://www.prisma.io/docs/orm/prisma-client/queries/query-optimization-performance#solving-n1-in-graphql-with-findunique-and-prisma-clients-dataloader) does not work as intended (see for example bugs with label topic: batching).

Right now, there is no way for our users to opt out of that functionality.
We should add one, disableQueryBatching: true or findUniqueBatching: false could work in some form.
@janpio janpio added kind/feature A request for a new feature. domain/client Issue in the "Client" domain: Prisma Client, Prisma Studio etc. topic: client api topic: batching labels Apr 4, 2024
@janpio janpio mentioned this issue Apr 4, 2024
Closed
@macrozone

This comment was marked as off-topic.

Sign in to view
@ericallam
Copy link

Would definitely be nice to be able to do this, as it recently caused outage on trigger.dev by doing a full table scan. ref: https://twitter.com/maverickdotdev/status/1800178147897561317

@jkomyno jkomyno mentioned this issue Jul 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain/client Issue in the "Client" domain: Prisma Client, Prisma Studio etc. kind/feature A request for a new feature. topic: batching topic: client api topic: performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ericallam @janpio @macrozone