Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade antlr to 4.9 #309

Closed
rootulp opened this issue Sep 8, 2021 · 1 comment
Closed

Upgrade antlr to 4.9 #309

rootulp opened this issue Sep 8, 2021 · 1 comment

Comments

@rootulp
Copy link

rootulp commented Sep 8, 2021

Currently, consumers of solhint will observe warnings like the following when running yarn install:

(node:7265) Warning: Accessing non-existent property 'INVALID_ALT_NUMBER' of module exports inside circular dependency
(node:7265) Warning: Accessing non-existent property 'INVALID_ALT_NUMBER' of module exports inside circular dependency

This is caused by antlr/antlr4#2834 and resolved by antlr/antlr4#2931 which was released in antlr 4.9. Therefore it would be awesome if solhint upgraded to this release.
@rootulp rootulp mentioned this issue Sep 8, 2021
Open
@dbale-altoros
Copy link
Collaborator

Updated to 4.11 in master branch. Will be included in next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rootulp @dbale-altoros