Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Array.prototype.filter is overwritten by prototype #337

Closed
welluh opened this issue Feb 12, 2018 · 1 comment
Closed

Native Array.prototype.filter is overwritten by prototype #337

welluh opened this issue Feb 12, 2018 · 1 comment

Comments

@welluh
Copy link

welluh commented Feb 12, 2018

I'm using Magento 1.9.3 with PrototypeJS version 1.7. which defines an Enumerable::findAll and the Enumerable methods are mixed in with Array.prototype, but fails to check if Array.prototype.filter already exists.

In the documentation here it states that native method will not be overwritten.

The real issue here is that Enumerable::findAll doesn't support third argument to the callback function of Array.prototype.filter().

Hope this issue could be fixed.

Kind regards,
-welluh-

@savetheclocktower
Copy link
Collaborator

Update to 1.7.3 to get this fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants