Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPython 6.0 support #28

Closed
pl31 opened this issue Apr 22, 2017 · 8 comments
Closed

IPython 6.0 support #28

pl31 opened this issue Apr 22, 2017 · 8 comments

Comments

@pl31
Copy link
Contributor

pl31 commented Apr 22, 2017

I just found, that IPython 6 is not supported, yet.

In a first step I tried to update the tox-Tests, but my travis build fails even for py{27,34}-ipython4, as it seems to install IPython6.

@rbhatia5
Copy link

I ran into this same problem, anybody have any ides if this is on the roadmap or if someone needs to take the time to add this feature?

@ssanderson
Copy link
Contributor

@rbhatia5 the environment in which I deploy pgcontents is still in python 2, which IPython 6 doesn't support, so I don't have much incentive to work on this. I'd accept a reasonable patch that fixed any incompatibilities with IPython 6 (I wouldn't expect there to be many if any) and updated the test matrix.

@rgbkrk
Copy link

rgbkrk commented Oct 18, 2018

It looks like the right support is now on master, which checks the notebook version rather than the ipython version. Just need a release at this point.

@jiyer2016
Copy link

I need this feature as well. Any idea when this might be released ?

@hynek2001
Copy link

ok guys. with respect to quantopian, i want to help a bit - seems it will take time before it hit pip.... 1. for installation get it from github directly pip install git+https://github.com/quantopian/pgcontents.git

then change in api_utils.py row 22

from
DUMMY_CREATED_DATE = datetime.fromtimestamp(0)

to
DUMMY_CREATED_DATE = datetime.now()

and it works - tested with python 3.6.5

@ssanderson
Copy link
Contributor

Hey all. I'm looking into cutting a 0.6 release now.

@devstein
Copy link

devstein commented Dec 9, 2019

For those who are only using HybridContentManager and want support for all IPython versions, see our hybridcontents fork

@ssanderson
Copy link
Contributor

Despite my previous comment, I never actually got around to cutting a 0.6 release...I just did so. Apologies for the delay!

https://github.com/quantopian/pgcontents/releases/tag/v0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants