Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow React 19 as a peer dependency #1455

Open
atomrevival opened this issue Jul 5, 2024 · 3 comments
Open

Allow React 19 as a peer dependency #1455

atomrevival opened this issue Jul 5, 2024 · 3 comments
Assignees
Labels
dependencies Pull requests that update a dependency file feature New feature or request

Comments

@atomrevival
Copy link

Problem

We're currently using this on a React 19 (RC) project and getting some peer dependencies. Seems that this works all right to just use the parser in a React 19 project, but haven't tested it conclusively.

Suggested Solution

{
  "peerDependencies": {
    "@types/react": "17 || 18",
    "react": "0.14 || 15 || 16 || 17 || 18 || 19"
  },
}

Keywords

React 19, upgrade, RC

@atomrevival atomrevival added the feature New feature or request label Jul 5, 2024
@remarkablemark
Copy link
Owner

@atomrevival thanks for opening this issue, I don't believe React 19 has been officially released yet (see NPM). In the meantime, could you try the following? #1436 (comment)

@remarkablemark remarkablemark added the dependencies Pull requests that update a dependency file label Jul 5, 2024
@remarkablemark remarkablemark pinned this issue Jul 5, 2024
@thany
Copy link

thany commented Aug 15, 2024

It's probably a good idea to stay ahead of issues like "please support React 19" when it does get released. Also, React 19 has RC status, which is especially the right moment for dependant packages to start adding support for it, in an effort to release an update on the same day as React does.

@remarkablemark
Copy link
Owner

@thany thanks for the comment. The reason why I'm not locking the RC version for React 19 is because it's still not stable.

If you need to use RC 19 in your project, feel free to follow #1436 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants