Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for release notes of #129021: Check WF of source type's signature on fn pointer cast #130000

Open
3 tasks
rustbot opened this issue Sep 5, 2024 · 1 comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes.
Milestone

Comments

@rustbot
Copy link
Collaborator

rustbot commented Sep 5, 2024

This issue tracks the release notes text for #129021.

  • Proposed text is drafted by PR author (or team) making the noteworthy change.
  • Issue is nominated for release team review of clarity for wider audience.
  • Release team includes text in release notes/blog posts.

Release notes text:

The responsible team for the underlying change should edit this section to replace the
automatically generated link with a succinct description of what changed, drawing upon text
proposed by the author (either in discussion or through direct editing). If the change is notable
enough for inclusion in the blog post, add content to the blog section below.

# Pick a category...
- [Check WF of source type's signature on fn pointer cast](https://github.com/rust-lang/rust/pull/129021)

Note: The section title will be de-duplicated by the release team with other release notes issues.
Please use a standard title from previous releases.
More than one section can be included if needed.

Release blog section (if any, leave blank if no section is expected):

cc @compiler-errors, @lcnr -- origin issue/PR authors and assignees for starting to draft text

@rustbot rustbot added relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Sep 5, 2024
@compiler-errors
Copy link
Member

compiler-errors commented Sep 5, 2024

Ooh this one will be difficult to write up a description for, though it's worth mentioning perhaps? It does break cve-rs, which is cool. though they could work around it if they tried harder...

This PR partly closes a soundness hole that comes when casting a function item to function pointer, but I'm not sure how best to describe it otherwise...

I don't expect users to hit this in practice, though, so I'm not totally sure if it needs relnotes...

@rustbot rustbot added this to the 1.83.0 milestone Sep 6, 2024
@saethlin saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes.
Projects
None yet
Development

No branches or pull requests

3 participants