Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for const fn <*T>::is_null #72198

Closed
3 tasks
oli-obk opened this issue May 14, 2020 · 3 comments
Closed
3 tasks

Tracking Issue for const fn <*T>::is_null #72198

oli-obk opened this issue May 14, 2020 · 3 comments
Labels
A-const-fn Area: const fn foo(..) {..}. Pure functions which can be applied at compile time. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@oli-obk
Copy link
Contributor

oli-obk commented May 14, 2020

This is a tracking issue for making the is_null method on raw pointers const fn
The feature gate for the issue is #![feature(const_ptr_is_null)].

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also uses as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

@oli-obk oli-obk added A-const-fn Area: const fn foo(..) {..}. Pure functions which can be applied at compile time. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. labels May 14, 2020
@jonas-schievink jonas-schievink added the T-lang Relevant to the language team, which will review and decide on the PR/issue. label May 14, 2020
@RalfJung
Copy link
Member

Cc @rust-lang/wg-const-eval

@RalfJung
Copy link
Member

Isn't this blocked on #53020 ? Right now, (&0 as *const _).is_null() will error even with Miri unleashed (and that is good, ptr comparison is a complicated subject).

@oli-obk
Copy link
Contributor Author

oli-obk commented May 15, 2020

yeaaa... I was a bit overexcited about this one. As my implementation quickly exploded to exactly what you're saying there. I'll close this issue again, there's no point in tracking it here. I'll just add it to the skill tree

@oli-obk oli-obk closed this as completed May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-const-fn Area: const fn foo(..) {..}. Pure functions which can be applied at compile time. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants