Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Servo’s style crate in cargotest? #79404

Open
SimonSapin opened this issue Nov 25, 2020 · 2 comments
Open

Restore Servo’s style crate in cargotest? #79404

SimonSapin opened this issue Nov 25, 2020 · 2 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@SimonSapin
Copy link
Contributor

src/tools/cargotest in this repository runs cargo test for a few crates as part of CI, including some of https://github.com/servo/servo/. This used to select the selectors and stylo_tests crates, whose dependency graph include most Servo crates that don’t rely on unstable language or std features.

In #54451 (comment) stylo_tests was removed. This in turn greatly reduced the coverage of what ends up being compiled during this test, since stylo_tests depended on the style crate which is one of the big components. With only the selectors crate and its dependency graph, much less of Servo is compiled which makes including Servo in cargotest less useful. On the other hand, compiling more stuff might increase the time taken by CI.

Some options here are:

// Only test Stylo a.k.a. Quantum CSS, the parts of Servo going into Firefox.
// This takes much less time to build than all of Servo and supports stable Rust.

@SimonSapin
Copy link
Contributor Author

CC @rust-lang/infra who might have thoughts about CI time

@pietroalbini pietroalbini added I-nominated T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 25, 2020
@shepmaster
Copy link
Member

Discussed in our meeting. We'd accept a PR re-adding it.

@Enselic Enselic added the A-testsuite Area: The testsuite used to check the correctness of rustc label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants