Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing A: Sync bound for Allocator for vec::IntoIter #92633

Closed
steffahn opened this issue Jan 7, 2022 · 0 comments · Fixed by #92879
Closed

Missing A: Sync bound for Allocator for vec::IntoIter #92633

steffahn opened this issue Jan 7, 2022 · 0 comments · Fixed by #92879
Labels
A-allocators Area: Custom and system allocators C-bug Category: This is a bug. I-unsound Issue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@steffahn
Copy link
Member

steffahn commented Jan 7, 2022 •
edited
Loading

I think this is an issue? Especially in light of IntoIter::allocating(&self) -> A existing. If so, the fix is trivial.

The instance in question: https://doc.rust-lang.org/nightly/std/vec/struct.IntoIter.html#impl-Sync

For comparison, the Send implementation right next to it does feature A: Send.
@compiler-errors compiler-errors mentioned this issue Jan 14, 2022
Merged
@camelid camelid added A-allocators Area: Custom and system allocators I-unsound Issue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jan 14, 2022
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jan 14, 2022
@camelid camelid added the C-bug Category: This is a bug. label Jan 14, 2022
@bors bors closed this as completed in 784e4ba Jan 15, 2022
@rustbot rustbot removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-allocators Area: Custom and system allocators C-bug Category: This is a bug. I-unsound Issue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Sync bound to allocator parameter in vec::IntoIter compiler-errors/rust
3 participants
@steffahn @camelid @rustbot