Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting multiline comments to single line breaks leading asterisks. #954

Open
paholg opened this issue Apr 20, 2016 · 2 comments
Open
Labels
a-comments bug Panic, non-idempotency, invalid code, etc. only-with-option requires a non-default option value to reproduce p-low

Comments

@paholg
Copy link

paholg commented Apr 20, 2016

This:

/*
**BOLD**
*italic*
*/

becomes:

// BOLD**
// italic*
//
@topecongiro topecongiro added a-comments only-with-option requires a non-default option value to reproduce poor-formatting labels Jun 25, 2017
@topecongiro topecongiro added bug Panic, non-idempotency, invalid code, etc. and removed poor-formatting labels Jun 7, 2020
@ytmimi
Copy link
Contributor

ytmimi commented Jul 19, 2022

Backlog triage:

Must set normalize_comments=true to reproduce, however the issue is not present if we rewrite the multi-line block comment with leading * on each line.

Input

/*
 * **BOLD**
 * *italic*
 */

Output

// **BOLD**
// *italic*

@calebcartwright this feels like the same underlying issue as the recently closed #5440, which had to do with the original code snippet not including the leading * for each line of the multi-line block comment. Rustfmt doesn't format markdown in line comments so it feels like there's no action to be taken on our end.

@ytmimi
Copy link
Contributor

ytmimi commented Jul 20, 2022

linking tracking issue for normaize_comments #3350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-comments bug Panic, non-idempotency, invalid code, etc. only-with-option requires a non-default option value to reproduce p-low
Projects
None yet
Development

No branches or pull requests

3 participants