Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Ready" shortcut should work on pull request review comments #1614

Closed
jyn514 opened this issue May 3, 2022 · 3 comments
Closed

The "Ready" shortcut should work on pull request review comments #1614

jyn514 opened this issue May 3, 2022 · 3 comments

Comments

@jyn514
Copy link
Member

jyn514 commented May 3, 2022

Right now it only works on top-level comments, not review comments.

Originally posted by @rustbot in rust-lang/rust#96584 (comment)

@apiraino
Copy link
Contributor

I'm trying to reproduce this on a local triagebot installation but so far no success.

@ehuss any suggestion? I see many occurrences of this in the rust-lang/rust pull requests but I'm blind since I don't have access to the logs (and we don't have a test repository, do we?)

@Mark-Simulacrum
Copy link
Member

I believe this is fixed -- I added logic but failed to close this issue (probably due to not knowing about it) to resolve this in #1619.

@apiraino
Copy link
Contributor

oh. Now I see :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants