Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sass-lint:disable-next-line #995

Closed
glen-84 opened this issue Jan 15, 2017 · 4 comments · Fixed by #1211
Closed

sass-lint:disable-next-line #995

glen-84 opened this issue Jan 15, 2017 · 4 comments · Fixed by #1211
Labels

Comments

@glen-84
Copy link
Contributor

glen-84 commented Jan 15, 2017

At the moment, you can do:

overflow-x: scroll !important; // sass-lint:disable-line no-important

Or:

// sass-lint:disable no-important
overflow-x: scroll !important;
// sass-lint:enable no-important

The first is not ideal when you want to add a reason/description and the line is already quite long, and the second is unnecessarily verbose.

TSLint supports a tslint:disable-next-line alternative, which would look like this:

// sass-lint:disable-next-line no-important -- The reason for this is because ...
overflow-x: scroll !important;

It would be nice to have this option.

@slavafomin
Copy link

A very nice feature to have, I was actually looking for it. Could you please tell me if PR is actually feature-complete and ready to be merged? Also, when is this planned to be released? Thank you.

@jgillman
Copy link

jgillman commented Mar 5, 2019

This would be extra-nice for Sass which doesn't seem to play nicely with inline comments after selectors.

✅ This is fine and works:

.foo
  color: red !important // sass-lint:disable-line no-important

💥 This blows up:

.foo // sass-lint:disable-line class-name-format
  color: red

@srowhani
Copy link
Member

🎉 This issue has been resolved in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@glen-84
Copy link
Contributor Author

glen-84 commented Apr 27, 2019

@srowhani Please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants