Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker: Migrate from in-repo mill plugin to external project #2818

Closed
5 tasks done
lefou opened this issue Dec 13, 2022 · 10 comments
Closed
5 tasks done

Tracker: Migrate from in-repo mill plugin to external project #2818

lefou opened this issue Dec 13, 2022 · 10 comments

Comments

@lefou
Copy link
Member

lefou commented Dec 13, 2022

Here is the plan:

@fthomas
Copy link
Member

fthomas commented Dec 13, 2022

This plan looks good to me.

Decide an a version scheme for external mill-plugin and make a first release

What kind of version scheme do you have in mind? I would probably just start with a 0.0.1 or 0.1.0 and check if it is working here.

@lefou
Copy link
Member Author

lefou commented Dec 13, 2022

This plan looks good to me.

Decide an a version scheme for external mill-plugin and make a first release

What kind of version scheme do you have in mind? I would probably just start with a 0.0.1 or 0.1.0 and check if it is working here.

I'd rather avoid any version collisions or confusion with previously released versions of this plugin (as part of scala-steward releases). Scala Steward is currently on 0.16.x, so maybe we can start with 0.17.0 or something like that.

@fthomas
Copy link
Member

fthomas commented Dec 13, 2022

I'd rather avoid any version collisions or confusion with previously released versions of this plugin (as part of scala-steward releases). Scala Steward is currently on 0.16.x, so maybe we can start with 0.17.0 or something like that.

Good point. I forgot that we already release the mill-plugin that is in this repo: https://repo1.maven.org/maven2/org/scala-steward/scala-steward-mill-plugin_2.13/ :-)

0.17.0 sounds good to me. Does the new plugin will have the same artifactId as the old one?

@lefou
Copy link
Member Author

lefou commented Dec 13, 2022

I'd rather avoid any version collisions or confusion with previously released versions of this plugin (as part of scala-steward releases). Scala Steward is currently on 0.16.x, so maybe we can start with 0.17.0 or something like that.

Good point. I forgot that we already release the mill-plugin that is in this repo: https://repo1.maven.org/maven2/org/scala-steward/scala-steward-mill-plugin_2.13/ :-)

0.17.0 sounds good to me. Does the new plugin will have the same artifactId as the old one?

In principle yes. (Currently, it's mill-scala-steward, but I'm going to change that.) But the final artifactId will also contain the Mill platform. E.g. the full GAV for Mill 0.10 version will eventually look like this: org.scala-steward:scala-steward-mill-plugin_mill0.10_2.13:0.17.0

@lefou
Copy link
Member Author

lefou commented Dec 14, 2022

Is there any documentation that needs change or additions?

@fthomas
Copy link
Member

fthomas commented Dec 14, 2022

I'm not aware of any existing documentation that needs to be updated.

@lefou
Copy link
Member Author

lefou commented Dec 14, 2022

Thank. I think this is completed now. Thank you all!

@lefou lefou closed this as completed Dec 14, 2022
@fthomas
Copy link
Member

fthomas commented Dec 14, 2022

Many thanks @lefou for working on this!

@fthomas
Copy link
Member

fthomas commented Dec 14, 2022

I guess it would be nice to release this soon. @scala-steward-org/core any objections against publishing current main as 0.17.0?

@fthomas
Copy link
Member

fthomas commented Dec 15, 2022

0.17.0 has just been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants