From 79c711d185858979f5ffb86a90eeab094c65703d Mon Sep 17 00:00:00 2001 From: Scaleway Bot Date: Thu, 7 Mar 2024 15:16:30 +0100 Subject: [PATCH] feat(redis): require the node_type field in MigrateClusterRequest (#3704) --- .../testdata/test-all-usage-redis-cluster-migrate-usage.golden | 2 +- docs/commands/redis.md | 2 +- internal/namespaces/redis/v1/redis_cli.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/scw/testdata/test-all-usage-redis-cluster-migrate-usage.golden b/cmd/scw/testdata/test-all-usage-redis-cluster-migrate-usage.golden index bd961cc2b4..1b89b7a903 100644 --- a/cmd/scw/testdata/test-all-usage-redis-cluster-migrate-usage.golden +++ b/cmd/scw/testdata/test-all-usage-redis-cluster-migrate-usage.golden @@ -7,7 +7,7 @@ USAGE: ARGS: [version] Redis™ engine version of the Database Instance - [node-type] Type of node to use for the Database Instance + node-type Type of node to use for the Database Instance [cluster-size] Number of nodes for the Database Instance cluster-id UUID of the Database Instance to update [zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | nl-ams-1 | nl-ams-2 | pl-waw-1 | pl-waw-2) diff --git a/docs/commands/redis.md b/docs/commands/redis.md index 6b54b4e559..4787f61146 100644 --- a/docs/commands/redis.md +++ b/docs/commands/redis.md @@ -287,7 +287,7 @@ scw redis cluster migrate [arg=value ...] | Name | | Description | |------|---|-------------| | version | | Redis™ engine version of the Database Instance | -| node-type | | Type of node to use for the Database Instance | +| node-type | Required | Type of node to use for the Database Instance | | cluster-size | | Number of nodes for the Database Instance | | cluster-id | Required | UUID of the Database Instance to update | | zone | Default: `fr-par-1`
One of: `fr-par-1`, `fr-par-2`, `nl-ams-1`, `nl-ams-2`, `pl-waw-1`, `pl-waw-2` | Zone to target. If none is passed will use default zone from the config | diff --git a/internal/namespaces/redis/v1/redis_cli.go b/internal/namespaces/redis/v1/redis_cli.go index f21a41195e..4b475a9893 100644 --- a/internal/namespaces/redis/v1/redis_cli.go +++ b/internal/namespaces/redis/v1/redis_cli.go @@ -421,7 +421,7 @@ func redisClusterMigrate() *core.Command { { Name: "node-type", Short: `Type of node to use for the Database Instance`, - Required: false, + Required: true, Deprecated: false, Positional: false, },