Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C-lightning deprecations #142

Closed
darosior opened this issue Mar 25, 2020 · 2 comments
Closed

C-lightning deprecations #142

darosior opened this issue Mar 25, 2020 · 2 comments

Comments

@darosior
Copy link

Hi,

For your interest ElementsProject/lightning#3603 removes some fields in the API which have been deprecated for several (6 iirc) months.

Namely:

  • The description field in sendpay.
  • The satoshi field in fundchannel_start (now amount). Note also this commit ElementsProject/lightning@49e2153 .
  • No more localfeatures and globalfeatures fields in listnodes, listpeers, peer_connected.
  • No more force bool in close.

Just wanted to make sure you were not relying on deprecated behavior before we release the breaking change !
@shesek
Copy link
Owner

shesek commented Mar 25, 2020

Thanks for bringing this to my attention!

Spark does not rely on any of them as far as I recall and I have been testing it with allow-deprecated-apis=false, but I'll make extra sure by testing against the rustyrussell:guilt/v082-deprecations branch.

@shesek
Copy link
Owner

shesek commented Mar 28, 2020

I tested, everything seems to work. Cheers!

@shesek shesek closed this as completed Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shesek @darosior