Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

See if blank space before comment gofmt difference between 1.5, 1.6 is worth fixing. #3

Closed
dmitshur opened this issue Mar 19, 2016 · 1 comment

Comments

@dmitshur
Copy link
Member

E.g., the following .go file was considered "gofmt"ed in 1.5 but no longer so in 1.6:

package main

import (
    "fmt"
    "runtime"

    // Some comment.
)

func main() {
    fmt.Println(runtime.Version())
}
@dmitshur
Copy link
Member Author

I was on the fence on this one for a while. One the one hand, the change in behavior is so insignificant, that spending time considering fixing it is probably not worth it. On the other hand, a gofmt regression is a pretty rare and interesting event, so perhaps it's worth to report (instead of forgetting) just because it may lead to interesting insights and lessons for future releases.

I tweeted about it and @adg suggested to just report it, so I've done so in golang/go#15294. This can be closed since it's being tracked there now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant