Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAX Push Parser should yield more specific information #61

Closed
halorgium opened this issue May 17, 2009 · 6 comments
Closed

SAX Push Parser should yield more specific information #61

halorgium opened this issue May 17, 2009 · 6 comments

Comments

@halorgium
Copy link

If possible, separating the XML namespaces from the attributes in the #start_element hook would be a big win.
And sending back the values as already-formed hashes would be nice too.

@sprsquish
Copy link
Contributor

I wrote a patch for this. It uses #start_element_ns and #end_element_ns. It maintains backward compatibility with #start_element and #end_element.

http://github.com/sprsquish/nokogiri/commit/775c298b49b0b085b024aa098aaf412b90269d4a

@tenderlove
Copy link
Member

I'm mostly OK with this patch. It shouldn't use rb_str_new2 as that will produce strings of the incorrect encoding in 1.9.

I'll apply it and fix it up.

@sprsquish
Copy link
Contributor

If you haven't already, I can clean it up and re-submit. Those rb_str_new2 calls were oversites on my part.

@tenderlove
Copy link
Member

If you don't mind, that would be great! If you clean up the rb_str_new2 calls, I'll apply it.

@sprsquish
Copy link
Contributor

Okay, I removed the direct calls to rb_str_new*, fixed the little space mistake in xml.rb and gave proper credit to the libxml guys.

I force updated the remote branch figuring no one else was paying any attention to my fork.

http://github.com/sprsquish/nokogiri/commit/660362805ff06cd36465d08bf6dda67af6867c4f

@tenderlove
Copy link
Member

applied. thanks!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants