Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add origin of sentences to GTheory #1837

Closed
tillmo opened this issue Mar 25, 2018 · 5 comments
Closed

add origin of sentences to GTheory #1837

tillmo opened this issue Mar 25, 2018 · 5 comments
Assignees

Comments

@tillmo
Copy link
Contributor

tillmo commented Mar 25, 2018

In Static.GTheory, the gTheorySens field of a GTheory should also contain information about the origin DG node and sentence of each sentence in the GTheory. This is needed for #1836.
The location to add this information is, besides, Static.GTheory, Static.AnalysisStructured, and Static.CompureTheory (especially computeLabelTheory).

@mcodescu
Copy link
Collaborator

What should I store for the origin sentence of a sentence? The origin sentence might live in a different logic, so this could get complicated. I was thinking of storing the name of the origin sentence, as they are unique for each node.

@tillmo
Copy link
Contributor Author

tillmo commented Mar 26, 2018

Yes, the name should suffice, and of course the id of the node, and the name of the development graph within the LibEnv.

@mcodescu
Copy link
Collaborator

The method computeLabelTheory takes as argument a LibEnv and a DGraph. Is there a way to get the name of the DGraph in that LibEnv, so we can save it in the origin of the sentences? Adding it as an argument (of type LibName) requires many changes in the functions that call, e.g. computeLabelTheory or computeDGraphTheories.

@tillmo
Copy link
Contributor Author

tillmo commented Mar 27, 2018

I think that the LibName should be added during static analysis, so that you won't need it as an extra argument in computeLabelTheory, because it is already present in the GTheorys.
Another option is to always store the LibName as part of the DGraph data structure.

@mcodescu
Copy link
Collaborator

mcodescu commented Apr 7, 2018

Fixed, see c632a2b

@mcodescu mcodescu closed this as completed Apr 7, 2018
@tillmo tillmo mentioned this issue Apr 7, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants