We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Negative values in histogram sometimes seem to lead to negative bin indices that can underflow (and shouldnt be there in the first place).
I believe the fix is in plotille/_util in hist() around line 85 to change the computation of x_idx to
x_idx = max(min(bins - 1, int(delta // xwidth)), 0)
(the max is new). Alas I don't have time to thoroughly test and/or create a PR right now, maybe someone else can pick it up
max
The text was updated successfully, but these errors were encountered:
I should add I'm using numpy arrays of int16s, seems even with the fix there is thus an issue with overflow/underflow
Sorry, something went wrong.
@audatic-henning Should be fixed in v3.7.2 . Can you please verify.
Solved it for me, thanks a lot for the quick solution!
Successfully merging a pull request may close this issue.
Negative values in histogram sometimes seem to lead to negative bin indices that can underflow (and shouldnt be there in the first place).
I believe the fix is in plotille/_util in hist() around line 85
to change the computation of x_idx to
(the
max
is new). Alas I don't have time to thoroughly test and/or create a PR right now, maybe someone else can pick it upThe text was updated successfully, but these errors were encountered: