Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Web compatibility issue with Magic360 #28

Open
evilpie opened this issue Sep 30, 2020 · 5 comments
Open

Web compatibility issue with Magic360 #28

evilpie opened this issue Sep 30, 2020 · 5 comments

Comments

@evilpie
Copy link

evilpie commented Sep 30, 2020

We have had the item method on Arrays in Firefox Nightly for about two or three days and just found our first web compatibility issue with the Magic 360 library: https://www.magictoolbox.com/magic360/examples/

https://bugzilla.mozilla.org/show_bug.cgi?id=1668342

@ljharb
Copy link
Member

ljharb commented Sep 30, 2020

Given that it's a paid library, is there any chance evangelism would be effective here?

@evilpie evilpie changed the title Web compatibilty issue with Magic360 Web compatibility issue with Magic360 Sep 30, 2020
@syg
Copy link
Collaborator

syg commented Oct 1, 2020

Aw man. Thanks for the debugging, @evilpie!

To summarize the Bugzilla bug, the issue seems to come down to the library treating the presence of .length and .item combined on an item to mean that it is an HTML collection.

We'll reach out to them as well.

@ljharb
Copy link
Member

ljharb commented Oct 1, 2020

It's unfortunate the web doesn't typically offer any kind of brand checks to identify elements/collections :-/ seems like it'd avoid this class of problem.

@evilpie
Copy link
Author

evilpie commented Oct 8, 2020

There is another issue with flickr.com: https://bugzilla.mozilla.org/show_bug.cgi?id=1669867. See #32

@karlcow
Copy link

karlcow commented Oct 8, 2020

Given that it's a paid library, is there any chance evangelism would be effective here?

Fixing the library is good. It is useful to understand how widespread it is and if it relies on a local install or not. Because fixing the library might not fix the websites.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants