Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better password management/hashing? #33

Closed
holow29 opened this issue Sep 10, 2021 · 1 comment · Fixed by #34
Closed

Better password management/hashing? #33

holow29 opened this issue Sep 10, 2021 · 1 comment · Fixed by #34
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@holow29
Copy link

holow29 commented Sep 10, 2021

It seems to me that this project uses the same password management (Digest/md5) as Baikal. Do you think it should be changed, based on the following:

sabre-io/Baikal#514
sabre-io/Baikal#868
@tchapi
Copy link
Owner

tchapi commented Sep 13, 2021

Hi @holow29

Yes it does use a md5 hash, and this is because Baikal and Davis still support the "legacy" Digest auth (see sabre-io/Baikal#514 (comment)).

I am in favor of ditching Digest altogether, but I have to take a deeper look at the consequences of that.

I will try to work on that soon.

@tchapi tchapi added enhancement New feature or request good first issue Good for newcomers labels Sep 13, 2021
@tchapi tchapi linked a pull request Sep 20, 2021 that will close this issue
Remove Digest auth #34
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Digest auth tchapi/davis
2 participants
@tchapi @holow29