Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a way to find out what will be changed by a builder before committing #74

Open
matko opened this issue Jun 21, 2021 · 0 comments

Comments

@matko
Copy link
Member

matko commented Jun 21, 2021

Simple builders currently save a list of additions and removals, both in id and string form (depending on how they come in), and process these lists at commit time to figure out what actually needs to happen.

In terminusdb, we're currently implementing a type of object whose identity is entirely dependent on their inner values - their id becomes a hash of those values. Multiple documents that point to this value will be pointing at the same object. This introduces a garbage collection problem where we'd like to delete this value object when the last reference to it is deleted. However, the way things are now, we can only figure out that the last reference got deleted after we have already done the commit.

We need some sort of inbetween phase, where the builder is not yet committed (we can still add extra additions/removals to it), but we do know exactly what would happen if it were to commit.

@github-actions github-actions bot added the triage issue to be triage label Jun 21, 2021
@spl spl removed the triage issue to be triage label Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants