Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy URL button does not seem to work #17

Open
raunofreiberg opened this issue Jan 10, 2020 · 2 comments
Open

Copy URL button does not seem to work #17

raunofreiberg opened this issue Jan 10, 2020 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@raunofreiberg
Copy link
Contributor

raunofreiberg commented Jan 10, 2020

I assume that the Copy URL button should work the same as it does in baseweb.design.

Although, out of the box, the code does not seem to be added as a parameter to the URL in the first place, hence the copy URL button has no effect.


I think this is the relevant logic: https://github.com/uber/baseweb/blob/b642d1bd81214dacb8ce05ad4aea1871e482a273/documentation-site/components/yard/index.tsx#L56.

Although, since react-view has no knowledge of a router and Storybook uses an iframe, I don't know if it's possible.

@tajo
Copy link
Member

tajo commented Jan 10, 2020

Yea, I had hard times with Storybook and updating/persisting the URL (I guess the iframe also doesn't help). So the URL copy feature is currently useless there. Might be fixable, I gave up pretty quick.

@tajo tajo added the help wanted Extra attention is needed label Jan 10, 2020
@raunofreiberg
Copy link
Contributor Author

I could technically get it working by messing with the browser history, but just inside the iframe.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants