Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Delete" button remains visible in the UI even after the editing period has expired. #1737

Closed
yakimka opened this issue Feb 2, 2024 · 3 comments · Fixed by #1751
Closed
Assignees
Milestone

Comments

@yakimka
Copy link

yakimka commented Feb 2, 2024

Steps to reproduce:

  1. Write a comment in remark42.
  2. Wait until the editing time is over.
  3. Click the "Delete" button.
  4. Nothing happens (as a user, I'm confused because there are no pop-ups or error messages).

Expected result:

  • The "Delete" button should not be visible in the UI after the editing period has expired.
  • OR perhaps the editing period applies only to editing, and message deletion is always available.
  • OR if deletion is not allowed and the button is available in UI, the user should be informed through a pop-up warning.
зображення
@umputun
Copy link
Owner

umputun commented Feb 2, 2024

@akellbl4 @paskal - I think it worked before; some regression?

@paskal
Copy link
Sponsor Collaborator

paskal commented Feb 14, 2024

@akellbl4, the problem was introduced in the 58b0841. I found this out using git bisect.

@paskal
Copy link
Sponsor Collaborator

paskal commented Mar 16, 2024

The "Delete" button should not be visible in the UI after the editing period has expired.

That option is the right one and was in place before the commit, where it was broken. It will be fixed shortly in the next release. Affected versions 1.10.0 - 1.12.1.

@paskal paskal added this to the v1.13.0 milestone Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants