Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing backslash in index.js file generated by iis preset #2012

Closed
jrojko opened this issue Dec 19, 2023 · 1 comment · Fixed by #2020
Closed

Missing backslash in index.js file generated by iis preset #2012

jrojko opened this issue Dec 19, 2023 · 1 comment · Fixed by #2020
Labels
pending triage preset:iis

Comments

@jrojko
Copy link

jrojko commented Dec 19, 2023

Environment

Node.js v20.9.0, Nuxt 3.8.2, Nitro 2.8.1

Reproduction

npx nuxi build --preset=iis_node

Describe the bug

The generated file index.js in the .output directory has a syntax error caused by a missing backslash (escape character) on this line:

if (process.env.PORT.startsWith('\')) {

This comes from src/presets/iis.ts, line 33 which should be changed to

if (process.env.PORT.startsWith('\\\\')) {

Additional context

No response

Logs

No response
@pi0 pi0 added the preset:iis label Dec 21, 2023
@jrojko jrojko closed this as completed Jan 2, 2024
@manniL
Copy link
Member

manniL commented Jan 2, 2024

Was fixed via #2020

@manniL manniL linked a pull request Jan 2, 2024 that will close this issue
fix(iisnode): correctly escape backslashes for port fix #2020
Merged
8 tasks
@jhony1104 jhony1104 mentioned this issue Feb 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pending triage preset:iis
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(iisnode): correctly escape backslashes for port fix unjs/nitro
3 participants
@manniL @pi0 @jrojko