Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Support for Flexbox, Grid, and other CSS properties #50

Open
wamoyo opened this issue Apr 18, 2020 · 4 comments
Open

Missing Support for Flexbox, Grid, and other CSS properties #50

wamoyo opened this issue Apr 18, 2020 · 4 comments

Comments

@wamoyo
Copy link
Collaborator

wamoyo commented Apr 18, 2020

Screenshot from 2020-04-17 22-10-26

Wondering how I might help on getting this up to date?

@wavded
Copy link
Owner

wavded commented Apr 20, 2020

You are most welcome to take a stab at this in a PR. I haven't used this lib in a while as I don't use stylus anymore, so I myself am a little out of sorts with how everything is setup. If I recall correctly, I believe we rely on the built in css.vim for a baseline but had brought in a number of styles that weren't supported (at the time) in the syntax file itself. They are likely 6-years out of date :D which makes sense given the properties missing you mention. It may just be finding another project with updated css syntax and copying them over to this project's syntax groups.

@wamoyo
Copy link
Collaborator Author

wamoyo commented Jun 25, 2020

Hey @wavded if you were willing to show me around the code a bit, so I understood it, I'd totally be willing to update the code so it supported modern CSS features. I use this vim plugin all the time, so I'd be more than happy to make the updates for myself and then set up pull requests.

I need a little help though. I'm not familiar enough with vim syntax highlighting and such.

@wavded
Copy link
Owner

wavded commented Jul 7, 2020

@wamoyo Thanks for your willingness to help out! I don't have much time at present to look at this. I am rusty at best on how to jump in myself, so I don't know how much I'd be able to help without relearning things myself. I based this on the vim-jade (now vim-pug) plugin when I initially worked on it:

https://github.com/digitaltoad/vim-pug

There may be things to glean there on how they updated things (although HTML elements don't change as often as CSS).

@wamoyo
Copy link
Collaborator Author

wamoyo commented Jul 10, 2020

@wavded Hmm... cool. Is there a resource you used originally to learn how to edit colorschemes for neovim? I would just need some support getting started. I might just fork in that case if that's okay : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants