Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing rectangle sizes, position and re-create rectangle before collecting region bounds #6

Open
Gigas002 opened this issue Apr 3, 2024 · 2 comments

Comments

@Gigas002
Copy link

Gigas002 commented Apr 3, 2024

Don't know much about waysip's inner implementation and wayland protocol stuff, so I can't provide a decent implementation, at least in a near future. Sorry.
Didn't dive deep into implementation, but I think watershot can be used as reference for this, since it has this functionality implemented. From higher level perspective, it looks like it's matching for application state (based on user input), while being in an endless loop, when the user does some nasty stuff with rectangle
As for user usage perspective, I think the feature can be hidden under a new flag, -A for example (as it was proposed in a similar PR for slurp)
Also, would be neat if we could also set the keybindings for this somehow (through args or config maybe?). watershot does this by matching on a Keysyms, so a similar approach can be used, I guess.

@Shinyzenith
Copy link
Member

This feature sounds good to me and I'll try to impl it when I get the time.

@Shinyzenith
Copy link
Member

Shinyzenith commented Apr 6, 2024

Apologies....wrong thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants