Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt test for video mime types in MapRecorderWin.spec.js #407

Open
chrismayer opened this issue Jun 20, 2024 · 0 comments
Open

Adapt test for video mime types in MapRecorderWin.spec.js #407

chrismayer opened this issue Jun 20, 2024 · 0 comments

Comments

@chrismayer
Copy link
Collaborator

The tests for mime types in MapRecorderWin.spec.js seem to have a bit of room for optimization. As stated by @sronveaux in #406

I was just thinking whether the test on default Chrome media possibilities was really useful written as is... it is run whatever the browser which is used to run the tests and so doesn't always give the expected result... and even with Chrome, it is only relevant if using the correct version of the browser... (...) I'd personally write a test to see if at least one format was available on the browser instead of testing a fixed list but it's only a suggestion...

Please share your thoughts about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant