From 2e9e3cf97fa961d8d1d099bdbfaec27dc185d995 Mon Sep 17 00:00:00 2001 From: Roman Zavodskikh Date: Wed, 25 Sep 2024 10:01:46 +0200 Subject: [PATCH] minor: remove unused endpointRegistry field from healthyEndpoints and fadeIn (#3248) Signed-off-by: Roman Zavodskikh --- proxy/fadein.go | 3 +-- proxy/fadein_internal_test.go | 2 +- proxy/healthy_endpoints.go | 1 - proxy/proxy.go | 4 +--- 4 files changed, 3 insertions(+), 7 deletions(-) diff --git a/proxy/fadein.go b/proxy/fadein.go index 80857b41f7..c9d898dfa9 100644 --- a/proxy/fadein.go +++ b/proxy/fadein.go @@ -9,8 +9,7 @@ import ( ) type fadeIn struct { - rnd *rand.Rand - endpointRegistry *routing.EndpointRegistry + rnd *rand.Rand } func (f *fadeIn) fadeInScore(lifetime time.Duration, duration time.Duration, exponent float64) float64 { diff --git a/proxy/fadein_internal_test.go b/proxy/fadein_internal_test.go index 8ebf92a9f4..6fccb060b1 100644 --- a/proxy/fadein_internal_test.go +++ b/proxy/fadein_internal_test.go @@ -92,7 +92,7 @@ func initializeEndpoints(endpointAges []float64, algorithmName string, fadeInDur registry.GetMetrics(eps[i]).SetDetected(detectionTimes[i]) } - proxy := &Proxy{registry: registry, fadein: &fadeIn{rnd: rand.New(loadbalancer.NewLockedSource()), endpointRegistry: registry}, quit: make(chan struct{})} + proxy := &Proxy{registry: registry, fadein: &fadeIn{rnd: rand.New(loadbalancer.NewLockedSource())}, quit: make(chan struct{})} return route, proxy, eps } diff --git a/proxy/healthy_endpoints.go b/proxy/healthy_endpoints.go index 70c0366361..8a1c9c6092 100644 --- a/proxy/healthy_endpoints.go +++ b/proxy/healthy_endpoints.go @@ -9,7 +9,6 @@ import ( type healthyEndpoints struct { rnd *rand.Rand - endpointRegistry *routing.EndpointRegistry maxUnhealthyEndpointsRatio float64 } diff --git a/proxy/proxy.go b/proxy/proxy.go index 0babad8da5..5c4fe9faca 100644 --- a/proxy/proxy.go +++ b/proxy/proxy.go @@ -841,7 +841,6 @@ func WithParams(p Params) *Proxy { if p.EnablePassiveHealthCheck { healthyEndpointsChooser = &healthyEndpoints{ rnd: rand.New(loadbalancer.NewLockedSource()), - endpointRegistry: p.EndpointRegistry, maxUnhealthyEndpointsRatio: p.PassiveHealthCheck.MaxUnhealthyEndpointsRatio, } } @@ -849,8 +848,7 @@ func WithParams(p Params) *Proxy { routing: p.Routing, registry: p.EndpointRegistry, fadein: &fadeIn{ - rnd: rand.New(loadbalancer.NewLockedSource()), - endpointRegistry: p.EndpointRegistry, + rnd: rand.New(loadbalancer.NewLockedSource()), }, heathlyEndpoints: healthyEndpointsChooser, roundTripper: p.CustomHttpRoundTripperWrap(tr),