Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent macro names #2849

Open
pepone opened this issue Oct 3, 2024 · 0 comments
Open

Inconsistent macro names #2849

pepone opened this issue Oct 3, 2024 · 0 comments
Labels
cleanup
Milestone
3.8.0

Comments

@pepone
Copy link
Member

pepone commented Oct 3, 2024 

#if !defined(ICE_BUILDING_ICE_STORM_LIB) && defined(ICESTORM_API_EXPORTS)
#    define ICE_BUILDING_ICE_STORM_LIB
#endif

Above we have both ICESTORM and ICE_STORM

Same issue with IceGrid

#if !defined(ICE_BUILDING_ICE_GRID) && defined(ICEGRID_API_EXPORTS)
#    define ICE_BUILDING_ICE_GRID
#endif

We should always use ICEGRID and ICESTORM in macro names.
@pepone pepone added the cleanup label Oct 3, 2024
@pepone pepone added this to the 3.8.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
3.8.0
Development

No branches or pull requests
1 participant
@pepone