Ini::section and Ini::index abuse a soundness hole

[arielb1]

The relevant code is

    pub fn section<'a: 'i, 'p>(&'a self, name: Option<&'p str>) -> Option<&'i Properties<'pk, 'pv>> {
        self.sections.get(&name.map(|s| s.into()))
    }

You access the sections HashMap, which has the type &'a HashMap<Option<Cow<'i, str>, _>, and you try to access it with an Option<Cow<'p, str>>. The lifetime mismatch is not detected by Rust 1.5, but will be detected by future versions of rustc.

index has a similar problem.

The only fix I am aware of is to turn the Cow to an owned one.

[zonyitoo]

Hmm, you are correct. Would you fire an PR?

[arielb1]

@zonyitoo

Would adding an allocation there be too bad?

[zonyitoo]

It shouldn't be too complicated to make all data to be owned by the Ini instance. Just replace all Cow to their owned version should be Ok.

I use Cow here just for learning how lifetime works (This is my first Rust project).

[zonyitoo]

I am going to fix this.