Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First stab at implementing benchmarks #165

Merged
merged 7 commits into from
Jun 5, 2020
Merged

First stab at implementing benchmarks #165

merged 7 commits into from
Jun 5, 2020

Conversation

purrgrammer
Copy link
Contributor

@purrgrammer purrgrammer commented Apr 3, 2020 •
edited
Loading

No description provided.

@purrgrammer purrgrammer marked this pull request as ready for review April 3, 2020 14:16
@purrgrammer
Copy link
Contributor Author

This is a first draft of the benchmarks, I'm working on including profiling and integration with sbt-hood but I'll add those in follow-up PRs.

BenFradet
BenFradet reviewed Apr 3, 2020
View reviewed changes
Copy link

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Last time I wrote jmh benchmarks I seem to recall they were advising for specifying different jvm options esp regarding gc but I can't find them anymore 🤷‍♂️

@purrgrammer purrgrammer requested a review from gutiory as a code owner June 2, 2020 09:38
@codecov
Copy link

codecov bot commented Jun 2, 2020 •
edited
Loading

Codecov Report

Merging #165 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          11       11           
  Lines          78       78           
  Branches        1        1           
=======================================
  Hits           77       77           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa2519f...d1e2356. Read the comment docs.

alejandrohdezma
alejandrohdezma approved these changes Jun 3, 2020
View reviewed changes
build.sbt Show resolved Hide resolved
build.sbt Show resolved Hide resolved
@gutiory
Disable scoverage plugin for benchmark project
04f5982 
Benchmark project is not a part of the library per se. So we keep it out of the code coverage.
@gutiory
Update readme with benchmarking documentation
d1e2356
@gutiory gutiory merged commit dcfe2f8 into master Jun 5, 2020
@gutiory gutiory deleted the bench branch June 5, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenFradet BenFradet BenFradet left review comments

@gutiory gutiory gutiory approved these changes

@alejandrohdezma alejandrohdezma alejandrohdezma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@purrgrammer @BenFradet @gutiory @alejandrohdezma